nix: use Nix Flake from NBS repo to provide Nim#3703
Open
Conversation
jakubgs
force-pushed
the
nix/use-nbs-flake
branch
from
b0b5091 to
8bf10c7
Compare
|
You can find the image built from this PR at Built from bb27cd1 |
markoburcul
approved these changes
Jan 29, 2026
Contributor
markoburcul
left a comment
markoburcul
left a comment
There was a problem hiding this comment.
Much more readable, great job. Shame that libwaku-android-arm64 can't be built, but that is not impacted by this pr:
logos-messaging-nim> Hint: [Link]
logos-messaging-nim> ld: error: unable to find library -lrln
logos-messaging-nim> clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
logos-messaging-nim> Error: execution of an external program failed: '/nix/store/hjyfpc9vzbd54fdzhv34c89bqy18s82s-androidsdk-mod-ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android30-clang @libwaku_linkerArgs.txt'
fba0b90 to
e0cc2f0
Compare
siddarthkay
approved these changes
Jan 30, 2026
jakubgs
force-pushed
the
nix/use-nbs-flake
branch
2 times, most recently
from
45ed31b to
0756c4e
Compare
jakubgs
force-pushed
the
nix/use-nbs-flake
branch
6 times, most recently
from
4ebdd73 to
d01508b
Compare
jakubgs
force-pushed
the
nix/use-nbs-flake
branch
from
d01508b to
0dc5f17
Compare
jakubgs
force-pushed
the
nix/use-nbs-flake
branch
from
0dc5f17 to
88b002b
Compare
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
jakubgs
force-pushed
the
nix/use-nbs-flake
branch
5 times, most recently
from
782df67 to
81f0338
Compare
This way we can avoid rebuilding Nim every time we build packages. Compilation of `libwaku` with Nim: 9 minutes Compilation of `libwaku` without Nim: 5 minutes Notably this upgrades: - Nim from 2.2.4 to 2.2.8. - Zerokit from 0.9.0 to 1.0.0. Also added CODEOWNERS file for CI and Nix configuration. Depends on: status-im/nimbus-build-system#112 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
nix/use-nbs-flake
branch
from
81f0338 to
bf7adcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we can avoid rebuilding Nim every time we build packages.
Compilation of
libwakuwith Nim: 9 minutesCompilation of
libwakuwithout Nim: 5 minutesNotably this upgrades:
2.2.4to2.2.8.0.9.0to1.0.0.Also added
CODEOWNERSfile for CI and Nix configuration.Depends on: