chore: provide an option to specify log level per topic#3611
chore: provide an option to specify log level per topic#3611chaitanyaprem wants to merge 2 commits intomasterfrom
Conversation
|
You can find the image built from this PR at Built from 066a5b1 |
|
Thanks for the PR @chaitanyaprem . Nevertheless, I'm not super convinced this is needed :) |
well, i think this would be a very useful feature for debugging. Becase right now if i enable trace level globally and want to debug there is a flood of logs and it becomes hard to filter things out especially when logs keep filling up disk space. |
7119981 to
e884162
Compare
e884162 to
c581ce7
Compare
ah okay I see, makes sense indeed. |
3b596ed to
e6e28c7
Compare
Description
Trying to provide a config to enable loglevel per topic.
Noticed a weird issue where while trying to set loglevel using the config it fails if the topics have spaces in them e.g "waku mix" and works without any issues when using
wakumixwithout spaces.Not sure if it is a bug in chronicles or something else.
Also i was not able to set the logLevel for underlying mix protocol code eventhough i have specified a topic name. Need to debug this.
Changes
Issue