Merged
Conversation
Collaborator
Author
|
Merging of this PR is blocked until @plopezlpz removes the DNM label. This change has impacts upstream consumers using dynamic linking. |
plopezlpz
approved these changes
Feb 21, 2026
osmaczko
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current build artifacts being generated by libchat are causing confusion at higher layers as pointed out by @plopezlpz .
liblogos_chat.*andliblogoschat.*This is because the crate name for libchat:conversations was named
logos_chat.This PR removes the confusion by renaming the crate to
libchatwhich then producesliblibchat.*artifacts.Notes:
liblibchatmight seem odd, but I believe this to make sense.Libchatfollows the established repo naming scheme for backend support libraries. The artifacts follow thelib{project_name}format.