Conversation
There was a problem hiding this comment.
hm. not a fan of using tailwindcss extensively but also relying on native CSS heavily at the same time
| let b = {}; | ||
| let o = false; |
There was a problem hiding this comment.
nit: some let keywords can be swapped for const keywords in the codebase
| import ShortUniqueId from 'short-unique-id'; | ||
| import Router from 'next/router'; | ||
|
|
||
| export default function Hero() { |
There was a problem hiding this comment.
what is the relevance of this component name
| if (room === null) { | ||
| setRoom(uid.rnd()); | ||
| } | ||
| }, []); |
There was a problem hiding this comment.
we should add room as a dependency to the useEffect
| sessionStorage.setItem('roomId', room); | ||
| sessionStorage.setItem('player', 'x'); |
There was a problem hiding this comment.
would be cool to use enums for this
| }; | ||
|
|
||
| const handleJoinGameClick = () => { | ||
| setGame('join'); |
There was a problem hiding this comment.
similar comment as above re enums
There was a problem hiding this comment.
this file can be broken down into more files for more readability
|
@vpavlin currently there is a problem with hosting Next.js apps - still didn't figure solution |
Can you elaborate the problem (in an issue if necessary)? |
3 participants
@weboko @danisharora099 Can you check? I am not sure if I missed anything necessary to get this in and deployed!