-
Notifications
You must be signed in to change notification settings - Fork 29
[FSTORE-1789] Data source docs #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Aleksey Veresov <[email protected]>
Co-authored-by: Aleksey Veresov <[email protected]>
|
||
=== "PySpark" | ||
```python | ||
import hopsworks | ||
# Connect to the Hopsworks feature store | ||
project = hopsworks.login() | ||
feature_store = project.get_feature_store() | ||
# Retrieve storage connector | ||
# Retrieve data source | ||
connector = feature_store.get_storage_connector('connector_name') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the example is outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a discussion and it was decided that api will remain unchanged for 4.3 and 4.4. in 4.5 we are updating it to be using data sources and deprecating storage connector (currently working on those changes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe at least change "connector_name" to something else? Is it the name of the saved credentials or the DS itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah i think all images are like this and i dont want to edit everything right now.
Co-authored-by: Aleksey Veresov <[email protected]>
Co-authored-by: Aleksey Veresov <[email protected]>
|
||
=== "PySpark" | ||
```python | ||
import hopsworks | ||
# Connect to the Hopsworks feature store | ||
project = hopsworks.login() | ||
feature_store = project.get_feature_store() | ||
# Retrieve storage connector | ||
# Retrieve data source | ||
connector = feature_store.get_storage_connector('connector_name') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe at least change "connector_name" to something else? Is it the name of the saved credentials or the DS itself?
Co-authored-by: Aleksey Veresov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! =)
No description provided.