Skip to content

[FSTORE-1789] Data source docs #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 11, 2025

Conversation

bubriks
Copy link
Contributor

@bubriks bubriks commented Jul 9, 2025

No description provided.


=== "PySpark"
```python
import hopsworks
# Connect to the Hopsworks feature store
project = hopsworks.login()
feature_store = project.get_feature_store()
# Retrieve storage connector
# Retrieve data source
connector = feature_store.get_storage_connector('connector_name')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the example is outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a discussion and it was decided that api will remain unchanged for 4.3 and 4.4. in 4.5 we are updating it to be using data sources and deprecating storage connector (currently working on those changes).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe at least change "connector_name" to something else? Is it the name of the saved credentials or the DS itself?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it makes sense to make them really bold, or white on color (like below), so that the numbers stick out a bit more. I have not noticed them at all at first. 😅

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i think all images are like this and i dont want to edit everything right now.


=== "PySpark"
```python
import hopsworks
# Connect to the Hopsworks feature store
project = hopsworks.login()
feature_store = project.get_feature_store()
# Retrieve storage connector
# Retrieve data source
connector = feature_store.get_storage_connector('connector_name')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe at least change "connector_name" to something else? Is it the name of the saved credentials or the DS itself?

Copy link
Contributor

@aversey aversey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! =)

@bubriks bubriks merged commit dc39fbf into logicalclocks:branch-4.3 Jul 11, 2025
1 check passed
bubriks added a commit to bubriks/logicalclocks.github.io that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants