Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on deployment wide search #454

Merged
merged 5 commits into from
Mar 12, 2025

Conversation

SirOibaf
Copy link
Contributor

No description provided.

@SirOibaf SirOibaf requested a review from Copilot March 12, 2025 22:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the documentation for Hopsworks' free-text search, with a focus on deployment-wide search capabilities. Key changes include:

  • Addition of YAML frontmatter for meta-description.
  • A dedicated section detailing search functionalities across projects.
  • Expanded explanation of asset visibility and a new "Tags" section.

@SirOibaf SirOibaf requested a review from Copilot March 12, 2025 22:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the documentation regarding deployment-wide search functionality.

  • Introduces YAML front matter with a description for the documentation page.
  • Adds new sections ("## Search" and "## Tags") to better structure and explain search capabilities and tagging details.
  • Clarifies the scope and limitations of search results based on project membership.
Comments suppressed due to low confidence (1)

docs/concepts/projects/search.md:20

  • Consider adding the missing closing parenthesis after the PII example for proper punctuation and readability.
A keyword is a single user-defined word attached to an ML asset. Keywords can be used to help it make it easier to find ML assets or understand the context in which they should be used (for example, *PII* could be used to indicate that the ML asset is based on personally identifiable information.
@SirOibaf SirOibaf requested a review from Copilot March 12, 2025 22:42
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve the documentation on deployment-wide search capabilities in Hopsworks by introducing a YAML front matter and reorganizing content for clearer guidance on ML asset discovery.

  • Added YAML front matter with a description.
  • Introduced a new "Search" section with a revised bullet list of searchable assets.
  • Expanded the text detailing search functionality and asset access limitations.

@SirOibaf SirOibaf merged commit e2217c3 into logicalclocks:main Mar 12, 2025
1 check passed
SirOibaf added a commit to SirOibaf/logicalclocks.github.io that referenced this pull request Mar 12, 2025
* Improve documentation on deployment wide search

* Update docs/concepts/projects/search.md

Co-authored-by: Copilot <[email protected]>

* add plural

* fix copilot suggestion

* add new line

---------

Co-authored-by: Copilot <[email protected]>
SirOibaf added a commit that referenced this pull request Mar 12, 2025
* Improve documentation on deployment wide search

* Update docs/concepts/projects/search.md



* add plural

* fix copilot suggestion

* add new line

---------

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants