1-macos-icloud-keychain-team-id-support - #2
Open
tombeckenham wants to merge 3 commits into
Open
Conversation
- Implement iCloud Keychain synchronization via kSecAttrSynchronizable - Add team ID/signature as accessor via kSecAttrAccessGroup - Support access group format "TEAMID.bundleid" for keychain sharing - Use enhanced SecItem API for advanced keychain features - Maintain full backward compatibility with existing API - Add comprehensive test coverage for new functionality - Document iCloud sync and access group usage requirements - Handle entitlement validation (error -34018 for missing provisioning) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
nickbeckenham
left a comment
nickbeckenham
left a comment
There was a problem hiding this comment.
can the description be a bit more use case friendly e.g. "enables the keyring library to use internet sync on icloud"
There was a problem hiding this comment.
If you want to contribute back to the core repo, I recommend removing this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com