Rename transfers, address reviewer comments Ref idaholab#29513

loganharbour · Nov 14, 2024 · 80f3ad8 · 80f3ad8
1 parent 7867ee4
commit 80f3ad8
Show file tree

Hide file tree

Showing 44 changed files with 378 additions and 327 deletions.
diff --git a/modules/subchannel/doc/content/source/auxkernels/QPrimeDuctAux.md b/modules/subchannel/doc/content/source/auxkernels/QPrimeDuctAux.md
diff --git a/...ntent/source/auxkernels/RZQPrimeAuxPin.md → ...nt/source/auxkernels/SCMRZPinQPrimeAux.md b/...ntent/source/auxkernels/RZQPrimeAuxPin.md → ...nt/source/auxkernels/SCMRZPinQPrimeAux.md
@@ -1,21 +1,21 @@
-# RZQPrimeAuxPin
+# SCMRZPinQPrimeAux
 
-!syntax description /AuxKernels/RZQPrimeAuxPin
+!syntax description /AuxKernels/SCMRZPinQPrimeAux
 
 ## Description
 
 <!-- -->
 
-The `RZQPrimeAuxPin` AuxKernel is used to compute the linear heat rate (w/m) on the surface of a fuel pin that is modeled with a 2D-RZ axi-symmetric mesh.
+The `SCMRZPinQPrimeAux` AuxKernel is used to compute the linear heat rate (w/m) on the surface of a fuel pin that is modeled with a 2D-RZ axi-symmetric mesh.
 It's a kernel that inherits from `DiffusionFluxAux` to calculate the flux, but in addition it multiplies with the pin diameter. The user needs to provide the
 diffusion coefficient and the temperature variable.
 
 ## Example Input File Syntax
 
 !listing /examples/coupling/1pinSquare_thermomech_SCM/one_pin_problem_sub.i block=AuxKernels language=cpp
 
-!syntax parameters /AuxKernels/RZQPrimeAuxPin
+!syntax parameters /AuxKernels/SCMRZPinQPrimeAux
 
-!syntax inputs /AuxKernels/RZQPrimeAuxPin
+!syntax inputs /AuxKernels/SCMRZPinQPrimeAux
 
-!syntax children /AuxKernels/RZQPrimeAuxPin
+!syntax children /AuxKernels/SCMRZPinQPrimeAux
diff --git a/modules/subchannel/doc/content/source/auxkernels/SCMTriDuctQPrimeAux.md b/modules/subchannel/doc/content/source/auxkernels/SCMTriDuctQPrimeAux.md
@@ -0,0 +1,15 @@
+# SCMTriDuctQPrimeAux
+
+!syntax description /AuxKernels/SCMTriDuctQPrimeAux
+
+## Description
+
+<!-- -->
+
+The `SCMTriDuctQPrimeAux` AuxKernel is used to compute the axial heat rate on a hexagonal duct surface.
+
+!syntax parameters /AuxKernels/SCMTriDuctQPrimeAux
+
+!syntax inputs /AuxKernels/SCMTriDuctQPrimeAux
+
+!syntax children /AuxKernels/SCMTriDuctQPrimeAux
diff --git a/...e/postprocessors/PinSurfaceTemperature.md → ...ostprocessors/SCMPinSurfaceTemperature.md b/...e/postprocessors/PinSurfaceTemperature.md → ...ostprocessors/SCMPinSurfaceTemperature.md
@@ -1,6 +1,6 @@
-# PinSurfaceTemperature
+# SCMPinSurfaceTemperature
 
-!syntax description /Postprocessors/PinSurfaceTemperature
+!syntax description /Postprocessors/SCMPinSurfaceTemperature
 
 ## Overview
 
@@ -13,14 +13,14 @@ The assumption is that each neighboring subchannel to a specific pin sees the sa
 Using the `Dittus-Boelter` approach we calculate surface temperatures for each neighbor. The numerical
 average is `Tpin`.
 
-Then, the postprocessor interpolates the value of the variable `Tpin` at a certain pin [!param](/Postprocessors/PinSurfaceTemperature/index) and [!param](/Postprocessors/PinSurfaceTemperature/height).
+Then, the postprocessor interpolates the value of the variable `Tpin` at a certain pin [!param](/Postprocessors/SCMPinSurfaceTemperature/index) and [!param](/Postprocessors/SCMPinSurfaceTemperature/height).
 
 ## Example Input File Syntax
 
 !listing /test/tests/problems/SFR/sodium-19pin/test19_monolithic.i block=Postprocessors language=cpp
 
-!syntax parameters /Postprocessors/PinSurfaceTemperature
+!syntax parameters /Postprocessors/SCMPinSurfaceTemperature
 
-!syntax inputs /Postprocessors/PinSurfaceTemperature
+!syntax inputs /Postprocessors/SCMPinSurfaceTemperature
 
-!syntax children /Postprocessors/PinSurfaceTemperature
+!syntax children /Postprocessors/SCMPinSurfaceTemperature
diff --git a/modules/subchannel/examples/ABR/Pr_SC_main_hc.i b/modules/subchannel/examples/ABR/Pr_SC_main_hc.i
@@ -11,12 +11,12 @@ outlet_pressure = 2.0e5 # Pa # gauge pressure
 ###################################################
 # units are cm - do not forget to convert to meter
 scale_factor = 0.01
-pin_pitch = ${fparse 0.8909*scale_factor}
-pin_diameter = ${fparse 0.755*scale_factor}
-wire_pitch = ${fparse 20.32*scale_factor}
-wire_diameter = ${fparse 0.1307*scale_factor}
-flat_to_flat = ${fparse 14.922*scale_factor}
-inter_wrapper_width = ${fparse 0.432*scale_factor}
+pin_pitch = '${fparse 0.8909*scale_factor}'
+pin_diameter = '${fparse 0.755*scale_factor}'
+wire_pitch = '${fparse 20.32*scale_factor}'
+wire_diameter = '${fparse 0.1307*scale_factor}'
+flat_to_flat = '${fparse 14.922*scale_factor}'
+inter_wrapper_width = '${fparse 0.432*scale_factor}'
 ###################################################
 #inter_wall_width = ${fparse outer_duct_in - inner_duct_out}
 
@@ -25,29 +25,29 @@ inter_wrapper_width = ${fparse 0.432*scale_factor}
 A12 = 1.00423e3
 A13 = -0.21390
 A14 = -1.1046e-5
-rho = ${fparse A12 + A13 * inlet_temperature + A14 * inlet_temperature * inlet_temperature}
+rho = '${fparse A12 + A13 * inlet_temperature + A14 * inlet_temperature * inlet_temperature}'
 #### Viscosity
 A52 = 3.6522e-5
 A53 = 0.16626
 A54 = -4.56877e1
 A55 = 2.8733e4
-mu = ${fparse A52 + A53 / inlet_temperature + A54 / inlet_temperature / inlet_temperature +
-        A55 / (inlet_temperature * inlet_temperature * inlet_temperature)}
+mu = '${fparse A52 + A53 / inlet_temperature + A54 / inlet_temperature / inlet_temperature +
+        A55 / (inlet_temperature * inlet_temperature * inlet_temperature)}'
 #### Specific heat at constant pressure
 A28 = 7.3898e5
 A29 = 3.154e5
 A30 = 1.1340e3
 A31 = -2.2153e-1
 A32 = 1.1156e-4
-dt = ${fparse 2503.3 - inlet_temperature}
-cp = ${fparse A28 / dt / dt + A29 / dt + A30 + A31 * dt + A32 * dt * dt}
+dt = '${fparse 2503.3 - inlet_temperature}'
+cp = '${fparse A28 / dt / dt + A29 / dt + A30 + A31 * dt + A32 * dt * dt}'
 #### Heat conduction coefficient
 A48 = 1.1045e2
 A49 = -6.5112e-2
 A50 = 1.5430e-5
 A51 = -2.4617e-9
-k = ${fparse A48 + A49 * inlet_temperature + A50 * inlet_temperature * inlet_temperature +
-        A51 * inlet_temperature * inlet_temperature * inlet_temperature}
+k = '${fparse A48 + A49 * inlet_temperature + A50 * inlet_temperature * inlet_temperature +
+        A51 * inlet_temperature * inlet_temperature * inlet_temperature}'
 #### Molar mass
 molar_mass = 22.989769e-3
 
@@ -62,7 +62,7 @@ cp_sodium = 300
 rho_sodium = 7800
 
 # hydraulic diameter
-D_hydraulic_interwrapper = ${fparse 2 * inter_wrapper_width}
+D_hydraulic_interwrapper = '${fparse 2 * inter_wrapper_width}'
 
 wrapper_blocks = 'wall'
 inter_wrapper_blocks = 'inter_wrapper'
@@ -114,9 +114,9 @@ inter_wrapper_blocks = 'inter_wrapper'
     v = duct_surface_temperature
   []
   [outside_bc]
-   type = NeumannBC
-   variable = T_wrapper
-   boundary = '10000 10001 10002'
+    type = NeumannBC
+    variable = T_wrapper
+    boundary = '10000 10001 10002'
   []
 []
 
@@ -142,7 +142,7 @@ inter_wrapper_blocks = 'inter_wrapper'
 
 [AuxKernels]
   [QPrime]
-    type = QPrimeDuctAux
+    type = SCMTriDuctQPrimeAux
     diffusivity = ${k_wrapper}
     flat_to_flat = ${flat_to_flat}
     variable = q_prime_duct
@@ -166,10 +166,10 @@ inter_wrapper_blocks = 'inter_wrapper'
   solve_type = 'PJFNK'
   petsc_options_iname = '-pc_type -pc_factor_mat_solver_package'
   petsc_options_value = 'lu superlu_dist'
-  fixed_point_max_its   = 5
+  fixed_point_max_its = 5
   fixed_point_min_its = 2
-  fixed_point_rel_tol   = 1e-4
-  fixed_point_abs_tol   = 1e-3
+  fixed_point_rel_tol = 1e-4
+  fixed_point_abs_tol = 1e-3
 
   [Quadrature]
     order = THIRD
@@ -213,10 +213,10 @@ inter_wrapper_blocks = 'inter_wrapper'
     variable = q_prime_duct
   []
 
-   [T_duct] # Recover T_duct from SC solve
-     type = MultiAppNearestNodeTransfer
-     from_multi_app = subchannel
-     source_variable = Tduct
-     variable = duct_surface_temperature
-   []
+  [T_duct] # Recover T_duct from SC solve
+    type = MultiAppNearestNodeTransfer
+    from_multi_app = subchannel
+    source_variable = Tduct
+    variable = duct_surface_temperature
+  []
 []
diff --git a/modules/subchannel/examples/ABR/Pr_SC_master_hc.i b/modules/subchannel/examples/ABR/Pr_SC_master_hc.i
@@ -13,12 +13,12 @@ outlet_pressure = 2.0e5 # Pa # gauge pressure
 ###################################################
 # units are cm - do not forget to convert to meter
 scale_factor = 0.01
-pin_pitch = ${fparse 0.8909*scale_factor}
-pin_diameter = ${fparse 0.755*scale_factor}
-wire_pitch = ${fparse 20.32*scale_factor}
-wire_diameter = ${fparse 0.1307*scale_factor}
-flat_to_flat = ${fparse 14.922*scale_factor}
-inter_wrapper_width = ${fparse 0.432*scale_factor}
+pin_pitch = '${fparse 0.8909*scale_factor}'
+pin_diameter = '${fparse 0.755*scale_factor}'
+wire_pitch = '${fparse 20.32*scale_factor}'
+wire_diameter = '${fparse 0.1307*scale_factor}'
+flat_to_flat = '${fparse 14.922*scale_factor}'
+inter_wrapper_width = '${fparse 0.432*scale_factor}'
 ###################################################
 #inter_wall_width = ${fparse outer_duct_in - inner_duct_out}
 
@@ -27,29 +27,29 @@ inter_wrapper_width = ${fparse 0.432*scale_factor}
 A12 = 1.00423e3
 A13 = -0.21390
 A14 = -1.1046e-5
-rho = ${fparse A12 + A13 * inlet_temperature + A14 * inlet_temperature * inlet_temperature}
+rho = '${fparse A12 + A13 * inlet_temperature + A14 * inlet_temperature * inlet_temperature}'
 #### Viscosity
 A52 = 3.6522e-5
 A53 = 0.16626
 A54 = -4.56877e1
 A55 = 2.8733e4
-mu = ${fparse A52 + A53 / inlet_temperature + A54 / inlet_temperature / inlet_temperature +
-        A55 / (inlet_temperature * inlet_temperature * inlet_temperature)}
+mu = '${fparse A52 + A53 / inlet_temperature + A54 / inlet_temperature / inlet_temperature +
+        A55 / (inlet_temperature * inlet_temperature * inlet_temperature)}'
 #### Specific heat at constant pressure
 A28 = 7.3898e5
 A29 = 3.154e5
 A30 = 1.1340e3
 A31 = -2.2153e-1
 A32 = 1.1156e-4
-dt = ${fparse 2503.3 - inlet_temperature}
-cp = ${fparse A28 / dt / dt + A29 / dt + A30 + A31 * dt + A32 * dt * dt}
+dt = '${fparse 2503.3 - inlet_temperature}'
+cp = '${fparse A28 / dt / dt + A29 / dt + A30 + A31 * dt + A32 * dt * dt}'
 #### Heat conduction coefficient
 A48 = 1.1045e2
 A49 = -6.5112e-2
 A50 = 1.5430e-5
 A51 = -2.4617e-9
-k = ${fparse A48 + A49 * inlet_temperature + A50 * inlet_temperature * inlet_temperature +
-        A51 * inlet_temperature * inlet_temperature * inlet_temperature}
+k = '${fparse A48 + A49 * inlet_temperature + A50 * inlet_temperature * inlet_temperature +
+        A51 * inlet_temperature * inlet_temperature * inlet_temperature}'
 #### Molar mass
 molar_mass = 22.989769e-3
 
@@ -64,7 +64,7 @@ cp_sodium = 300
 rho_sodium = 7800
 
 # hydraulic diameter
-D_hydraulic_interwrapper = ${fparse 2 * inter_wrapper_width}
+D_hydraulic_interwrapper = '${fparse 2 * inter_wrapper_width}'
 
 wrapper_blocks = 'wall'
 inter_wrapper_blocks = 'inter_wrapper'
@@ -116,9 +116,9 @@ inter_wrapper_blocks = 'inter_wrapper'
     v = duct_surface_temperature
   []
   [outside_bc]
-   type = NeumannBC
-   variable = T_wrapper
-   boundary = '10000 10001 10002'
+    type = NeumannBC
+    variable = T_wrapper
+    boundary = '10000 10001 10002'
   []
 []
 
@@ -144,7 +144,7 @@ inter_wrapper_blocks = 'inter_wrapper'
 
 [AuxKernels]
   [QPrime]
-    type = QPrimeDuctAux
+    type = SCMTriDuctQPrimeAux
     diffusivity = ${k_wrapper}
     flat_to_flat = ${flat_to_flat}
     variable = q_prime_duct
@@ -168,10 +168,10 @@ inter_wrapper_blocks = 'inter_wrapper'
   solve_type = 'PJFNK'
   petsc_options_iname = '-pc_type -pc_factor_mat_solver_package'
   petsc_options_value = 'lu superlu_dist'
-  fixed_point_max_its   = 5
+  fixed_point_max_its = 5
   fixed_point_min_its = 2
-  fixed_point_rel_tol   = 1e-4
-  fixed_point_abs_tol   = 1e-3
+  fixed_point_rel_tol = 1e-4
+  fixed_point_abs_tol = 1e-3
 
   [Quadrature]
     order = THIRD
@@ -215,10 +215,10 @@ inter_wrapper_blocks = 'inter_wrapper'
     variable = q_prime_duct
   []
 
-   [T_duct] # Recover T_duct from SC solve
-     type = MultiAppNearestNodeTransfer
-     from_multi_app = subchannel
-     source_variable = Tduct
-     variable = duct_surface_temperature
-   []
+  [T_duct] # Recover T_duct from SC solve
+    type = MultiAppNearestNodeTransfer
+    from_multi_app = subchannel
+    source_variable = Tduct
+    variable = duct_surface_temperature
+  []
 []
diff --git a/modules/subchannel/examples/ABTR/ABTR_core/pin.i b/modules/subchannel/examples/ABTR/ABTR_core/pin.i
@@ -1,15 +1,15 @@
 T_in = 630 # K
 reactor_power = 250e6 #WTh
-fuel_assemblies_per_power_unit = ${fparse 2}
+fuel_assemblies_per_power_unit = '${fparse 2}'
 fuel_pins_per_assembly = 217
-pin_power = ${fparse reactor_power/(fuel_assemblies_per_power_unit*fuel_pins_per_assembly)} # Approx.
+pin_power = '${fparse reactor_power/(fuel_assemblies_per_power_unit*fuel_pins_per_assembly)}' # Approx.
 
 scale_factor = 0.01
-fuel_pin_diameter= ${fparse 0.8*scale_factor}
-length_entry_fuel = ${fparse 60*scale_factor}
-length_heated_fuel = ${fparse 80*scale_factor}
-length_outlet_fuel = ${fparse 120*scale_factor}
-height = ${fparse length_entry_fuel+length_heated_fuel+length_outlet_fuel}
+fuel_pin_diameter = '${fparse 0.8*scale_factor}'
+length_entry_fuel = '${fparse 60*scale_factor}'
+length_heated_fuel = '${fparse 80*scale_factor}'
+length_outlet_fuel = '${fparse 120*scale_factor}'
+height = '${fparse length_entry_fuel+length_heated_fuel+length_outlet_fuel}'
 
 [Mesh]
   second_order = true
@@ -27,7 +27,7 @@ height = ${fparse length_entry_fuel+length_heated_fuel+length_outlet_fuel}
     pin_type = 1
     pitch = 0.012
     num_sectors = 4
-    region_ids='1 2 3 4'
+    region_ids = '1 2 3 4'
     ring_radii = '${fparse fuel_pin_diameter/2}
                   ${fparse fuel_pin_diameter/2 + 1e-5}
                   ${fparse fuel_pin_diameter/2 + 2e-5}'
@@ -72,7 +72,6 @@ height = ${fparse length_entry_fuel+length_heated_fuel+length_outlet_fuel}
     old_block = '1'
     new_block = 'fuel_pin'
   []
-
 []
 
 [Functions]
@@ -103,7 +102,7 @@ height = ${fparse length_entry_fuel+length_heated_fuel+length_outlet_fuel}
 
 [AuxKernels]
   [QPrime]
-    type = RZQPrimeAuxPin
+    type = SCMRZPinQPrimeAux
     diffusivity = 'thermal_conductivity'
     variable = q_prime_pin
     diffusion_variable = temperature