Allow sections & snippets within subfolders#142
Open
westonganger wants to merge 1 commit intolocomotivecms:masterfrom
Open
Allow sections & snippets within subfolders#142westonganger wants to merge 1 commit intolocomotivecms:masterfrom
westonganger wants to merge 1 commit intolocomotivecms:masterfrom
Conversation
Member
|
thanks @westonganger! I think I can fix the deployment thing. |
Member
|
In order to avoid slug collisions, I suggest that the convention for the section slug should be Examples: @westonganger what do you think? |
Contributor
Author
|
I would definitely prefer to refer to them via the path However under the hood for the slug, I would propose the following (in order of preference)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves locomotivecms/engine#1313
[WIP] currently only works locally with
wagon serve, deploying has issues which can be solved using encoding and decoding of the url.