Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update, cleanup of broken and added a few links #391

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CancianMatteo
Copy link

Tags have been reordered, from: "children", "name", "type"; to: "name", "type", "children" (more easily readable).

@s0lray
Copy link
Contributor

s0lray commented Jul 2, 2024

These are a LOT of changes. It will take me a few days to parse through them all probably. I already pushed a reorder of the json fields. That was a good idea. Diff'ing the adds and removes next.

@CancianMatteo
Copy link
Author

These are a LOT of changes. It will take me a few days to parse through them all probably. I already pushed a reorder of the json fields. That was a good idea. Diff'ing the adds and removes next.

Yeah, there are many changes, merging was (and still is) a mess, but I can ensure you that it will worth it, i cleaned up many broken links and formatted better the json. You can freely verify them all...

@CancianMatteo
Copy link
Author

I've also already updated my repo manually with the last commits and accepted PR of this repo

@CancianMatteo
Copy link
Author

I saw that in a past commit you reordered the tags by yourself, instead of accepting my PR...
Would you please make me active contributor of this? I think that I deserve it for the efforts I put on this

@CancianMatteo
Copy link
Author

I just did a commit with all the updates you did in the last month, my arf.json is still about 700 rows shorter than yours, this means you have many broken links inside...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants