Skip to content

Fix RasterJoin and toLayer crs and extent column name search #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix RasterJoin and toLayer crs and extent column name search #504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions core/src/test/scala/org/locationtech/rasterframes/RasterLayerSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,39 @@ class RasterLayerSpec extends TestEnvironment with MetadataKeys
prt.extent should be(extent)
}

it("should create layer from arbitrarily named tile, crs, extent type columns") {
val src = RFRasterSource(URI.create("https://raw.githubusercontent.com/locationtech/rasterframes/develop/core/src/test/resources/LC08_RGB_Norfolk_COG.tiff"))
val srcCrs = src.crs

val rasters = src.readAll()
.map(r ⇒ ProjectedRasterTile(r.tile.bands.head, r.extent, srcCrs))

// this sets up the condition we are trying to test in this. No ProjectedRasterTile and "nonstandard" names.
val df = rasters.toDF("red")
.select(rf_tile($"red"), rf_extent($"red") as "red_extent", rf_crs($"red") as "red_crs")

val crs = CRS.fromString("+proj=utm +zone=18 +datum=WGS84 +units=m +no_defs")

val extent = Extent(364455.0, 4080315.0, 395295.0, 4109985.0)
val layout = LayoutDefinition(extent, TileLayout(2, 2, 32, 32))

val tlm = new TileLayerMetadata[SpatialKey](
UByteConstantNoDataCellType,
layout,
extent,
crs,
KeyBounds(SpatialKey(0, 0), SpatialKey(1, 1))
)

val Dimensions(cols, rows) = tlm.totalDimensions
// this is what we are really trying to exercise here
val layer = df.toLayer(tlm)
val prt = layer.toRaster($"red", cols.toInt, rows.toInt)

prt.tile.dimensions should be (Dimensions(cols, rows))
prt.crs should be(crs)
}

it("shouldn't clip already clipped extents") {
val rf = TestData.randomSpatialTileLayerRDD(1024, 1024, 8, 8).toLayer

Expand Down