Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› fix: Fix Code blocks direction in lists #259

Merged

Conversation

alirezaImani-f4L3e
Copy link
Contributor

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • Fix code blocks direction in high level component styling (including list items)

  • โœจ feat

  • ๐Ÿ› fix

  • โ™ป๏ธ refactor

  • ๐Ÿ’„ style

  • ๐Ÿ”จ chore

  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

I have changed text-align property of the shiki class style to start that all code blocks (in any component ) direction turn to ltr

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Updated (UTC)
lobe-ui โœ… Ready (Inspect) Visit Preview Feb 5, 2025 3:43pm

@lobehubbot
Copy link
Member

๐Ÿ‘ @alirezaImani-f4L3e


Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 1.35%. Comparing base (5851677) to head (6043ab0).
Report is 316 commits behind head on master.

Files with missing lines Patch % Lines
src/Highlighter/SyntaxHighlighter/style.ts 0.00% 2 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #259      +/-   ##
=========================================
+ Coverage    0.00%   1.35%   +1.35%     
=========================================
  Files         330     473     +143     
  Lines       22325   19376    -2949     
  Branches      330     493     +163     
=========================================
+ Hits            0     263     +263     
+ Misses      21995   18835    -3160     
+ Partials      330     278      -52     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Feb 5, 2025

Open in Stackblitz

npm i https://pkg.pr.new/lobehub/lobe-ui/@lobehub/ui@259

commit: 6043ab0

@canisminor1990 canisminor1990 merged commit af5ce46 into lobehub:master Feb 5, 2025
7 of 8 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @alirezaImani-f4L3e โค๏ธ


The growth of project is inseparable from user feedback and contribution, thanks for your contribution!
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ!

github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
### [Version 1.164.11](v1.164.10...v1.164.11)
<sup>Released on **2025-02-05**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Fix Code blocks direction in lists.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix Code blocks direction in lists, closes [#259](#259) ([af5ce46](af5ce46))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.164.11 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-ui that referenced this pull request Feb 5, 2025
### [Version&nbsp;1.34.8](v1.34.7...v1.34.8)
<sup>Released on **2025-02-05**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Fix Code blocks direction in lists.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix Code blocks direction in lists, closes [lobehub#259](https://github.com/bentwnghk/lobe-ui/issues/259) ([af5ce46](af5ce46))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants