Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ› fix: hide tooltip on clicking action icon #183

Merged
merged 1 commit into from
Jul 15, 2024
Merged

๐Ÿ› fix: hide tooltip on clicking action icon #183

merged 1 commit into from
Jul 15, 2024

Conversation

phuctm97
Copy link
Contributor

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ”จ chore
  • ๐Ÿ“ docs

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

Currently, if clicking on <ActionIcon /> moves the <ActionIcon /> away from the cursor immediately, the tooltip will get stuck, which causes bad user experience. This PR hides tooltip automatically when clicking on the <ActionIcon /> to solve this issue.

@lobehubbot
Copy link
Member

๐Ÿ‘ @phuctm97


Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@codecov Codecov
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 0.18%. Comparing base (5851677) to head (d08f13a).
Report is 103 commits behind head on master.

Files Patch % Lines
src/ActionIcon/index.tsx 0.00% 22 Missing โš ๏ธ
Additional details and impacted files 
@@            Coverage Diff            @@
##           master    #183      +/-   ##
=========================================
+ Coverage    0.00%   0.18%   +0.18%     
=========================================
  Files         330     354      +24     
  Lines       22325   23822    +1497     
  Branches      330     367      +37     
=========================================
+ Hits            0      43      +43     
- Misses      21995   23426    +1431     
- Partials      330     353      +23

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@canisminor1990 canisminor1990 merged commit 4e81d94 into lobehub:master Jul 15, 2024
6 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @phuctm97 โค๏ธ


The growth of project is inseparable from user feedback and contribution, thanks for your contribution!
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ!

github-actions bot pushed a commit that referenced this pull request Jul 15, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v1.146.7 [skip ci]
9db8955 
### [Version&nbsp;1.146.7](v1.146.6...v1.146.7)
<sup>Released on **2024-07-15**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Hide tooltip on clicking action icon.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Hide tooltip on clicking action icon, closes [#183](#183) ([4e81d94](4e81d94))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.146.7 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-ui that referenced this pull request Jul 15, 2024
@semantic-release-bot
๐Ÿ”– chore(release): v1.18.4 [skip ci]
0621af8 
### [Version&nbsp;1.18.4](v1.18.3...v1.18.4)
<sup>Released on **2024-07-15**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Hide tooltip on clicking action icon.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Hide tooltip on clicking action icon, closes [lobehub#183](https://github.com/bentwnghk/lobe-ui/issues/183) ([4e81d94](4e81d94))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
ReneDrengen pushed a commit to ReneDrengen/lobe-ui that referenced this pull request Sep 18, 2024
@phuctm97 @ReneDrengen
๐Ÿ› fix: hide tooltip on clicking action icon (lobehub#183)
e415776
ReneDrengen pushed a commit to ReneDrengen/lobe-ui that referenced this pull request Sep 18, 2024
@semantic-release-bot @ReneDrengen
๐Ÿ”– chore(release): v1.146.7 [skip ci]
69aaf86 
### [Version&nbsp;1.146.7](lobehub/lobe-ui@v1.146.6...v1.146.7)
<sup>Released on **2024-07-15**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Hide tooltip on clicking action icon.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Hide tooltip on clicking action icon, closes [lobehub#183](lobehub#183) ([4e81d94](lobehub@4e81d94))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phuctm97 @lobehubbot @canisminor1990