Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Extra Backslash in Code Blocks ($0 -> /$0) #177

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

sxjeru
Copy link
Contributor

@sxjeru sxjeru commented Jul 5, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

🔀 变更说明 | Description of Change

image

fix lobehub/lobe-chat#3147

📝 补充信息 | Additional Information

@lobehubbot
Copy link
Member

👍 @sxjeru


Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.18%. Comparing base (5851677) to head (bfaf239).
Report is 98 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #177      +/-   ##
=========================================
+ Coverage    0.00%   0.18%   +0.18%     
=========================================
  Files         330     354      +24     
  Lines       22325   23786    +1461     
  Branches      330     367      +37     
=========================================
+ Hits            0      43      +43     
- Misses      21995   23390    +1395     
- Partials      330     353      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加个单测用例吧,不然无法确保变更不会影响其他case

@sxjeru sxjeru requested a review from arvinxx July 7, 2024 07:24
@canisminor1990 canisminor1990 merged commit f77df56 into lobehub:master Jul 8, 2024
5 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @sxjeru ❤️


The growth of project is inseparable from user feedback and contribution, thanks for your contribution!
项目的成长离不开用户反馈和贡献,感谢您的贡献!

github-actions bot pushed a commit that referenced this pull request Jul 8, 2024
### [Version 1.146.5](v1.146.4...v1.146.5)
<sup>Released on **2024-07-08**</sup>

#### 🐛 Bug Fixes

- **misc**: Extra Backslash in Code Blocks ($0 -> /$0), highlighter scroll bugs.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Extra Backslash in Code Blocks ($0 -> /$0), closes [#177](#177) ([f77df56](f77df56))
* **misc**: Highlighter scroll bugs, closes [#178](#178) ([079bc9a](079bc9a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.146.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-ui that referenced this pull request Jul 8, 2024
### [Version&nbsp;1.18.2](v1.18.1...v1.18.2)
<sup>Released on **2024-07-08**</sup>

#### 🐛 Bug Fixes

- **misc**: Extra Backslash in Code Blocks ($0 -> /$0), highlighter scroll bugs.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Extra Backslash in Code Blocks ($0 -> /$0), closes [lobehub#177](https://github.com/bentwnghk/lobe-ui/issues/177) ([f77df56](f77df56))
* **misc**: Highlighter scroll bugs, closes [lobehub#178](https://github.com/bentwnghk/lobe-ui/issues/178) ([079bc9a](079bc9a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@sxjeru sxjeru deleted the patch-2 branch August 24, 2024 05:40
ReneDrengen pushed a commit to ReneDrengen/lobe-ui that referenced this pull request Sep 18, 2024
* Update utils.ts

* fix: Update escapeDollarNumber function to handle code blocks and single line code blocks

* Create utils.test.ts

* Update utils.test.ts
ReneDrengen pushed a commit to ReneDrengen/lobe-ui that referenced this pull request Sep 18, 2024
### [Version&nbsp;1.146.5](lobehub/lobe-ui@v1.146.4...v1.146.5)
<sup>Released on **2024-07-08**</sup>

#### 🐛 Bug Fixes

- **misc**: Extra Backslash in Code Blocks ($0 -> /$0), highlighter scroll bugs.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Extra Backslash in Code Blocks ($0 -> /$0), closes [lobehub#177](lobehub#177) ([f77df56](lobehub@f77df56))
* **misc**: Highlighter scroll bugs, closes [lobehub#178](lobehub#178) ([079bc9a](lobehub@079bc9a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] extra backslash appears before the dollar sign in code blocks
4 participants