Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style: Expose tooltip overlayStyle prop #162

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

sxjeru
Copy link
Contributor

@sxjeru sxjeru commented Jun 4, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • 📝 docs

🔀 变更说明 | Description of Change

由于 Antd Tooltip 默认限制宽度为 250px,导致出现以下问题。

image

更改后:

image

📝 补充信息 | Additional Information

另可考虑设置为 'none' 。

@lobehubbot
Copy link
Member

👍 @sxjeru


Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@canisminor1990
Copy link
Member

这个我建议直接改chat里的 大部分地方还是有最大宽度效果比较好

@canisminor1990
Copy link
Member

@sxjeru

@sxjeru
Copy link
Contributor Author

sxjeru commented Jun 7, 2024

lobe-chat 相关代码:
https://github.com/lobehub/lobe-chat/blob/41d96bef1485850907a111a0b2c7362ce5bc3ce2/src/features/ChatInput/ActionBar/Clear.tsx#L40

要修改的属性目前没有暴露,所以不清楚怎么在 chat 那边改。
这边试试让组件暴露 overlayStyle 。

@sxjeru sxjeru changed the title 💄 style: Expand tooltip default maxWidth 💄 style: Expose tooltip overlayStyle prop Jun 8, 2024
@canisminor1990 canisminor1990 merged commit 23a4fa0 into lobehub:master Jun 9, 2024
2 of 3 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @sxjeru ❤️


The growth of project is inseparable from user feedback and contribution, thanks for your contribution!
项目的成长离不开用户反馈和贡献,感谢您的贡献!

github-actions bot pushed a commit that referenced this pull request Jun 9, 2024
### [Version 1.142.3](v1.142.2...v1.142.3)
<sup>Released on **2024-06-09**</sup>

#### 💄 Styles

- **misc**: Expose `tooltip` overlayStyle prop.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Expose `tooltip` overlayStyle prop, closes [#162](#162) ([23a4fa0](23a4fa0))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@sxjeru sxjeru deleted the patch-3 branch June 9, 2024 09:30
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.142.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@@ -47,7 +48,7 @@ export interface ActionIconProps extends LucideIconProps, FlexboxProps {
* @description Set the loading status of ActionIcon
*/
loading?: boolean;

overlayStyle?: React.CSSProperties;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个写法有问题的,不应该引入 React ,应该直接引入 CSSProperties

@sxjeru sxjeru mentioned this pull request Jun 9, 2024
6 tasks
github-actions bot pushed a commit to bentwnghk/lobe-ui that referenced this pull request Jun 9, 2024
### [Version&nbsp;1.14.3](v1.14.2...v1.14.3)
<sup>Released on **2024-06-09**</sup>

#### 💄 Styles

- **misc**: Expose `tooltip` overlayStyle prop.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Expose `tooltip` overlayStyle prop, closes [lobehub#162](https://github.com/bentwnghk/lobe-ui/issues/162) ([23a4fa0](23a4fa0))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
ReneDrengen pushed a commit to ReneDrengen/lobe-ui that referenced this pull request Sep 18, 2024
* Update index.tsx

* expose tooltip overlayStyle

* Update index.tsx
ReneDrengen pushed a commit to ReneDrengen/lobe-ui that referenced this pull request Sep 18, 2024
### [Version&nbsp;1.142.3](lobehub/lobe-ui@v1.142.2...v1.142.3)
<sup>Released on **2024-06-09**</sup>

#### 💄 Styles

- **misc**: Expose `tooltip` overlayStyle prop.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Expose `tooltip` overlayStyle prop, closes [lobehub#162](lobehub#162) ([23a4fa0](lobehub@23a4fa0))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants