slight simplifications of configs in favor of consistency#252
Merged
AlexanderFengler merged 1 commit intomainfrom Jan 9, 2026
Merged
slight simplifications of configs in favor of consistency#252AlexanderFengler merged 1 commit intomainfrom
AlexanderFengler merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the utility functions for model configuration from
ssms/config/_modelconfig/utils.pyand deletes their associated unit tests intests/test_modelconfig_utils.py. This is a cleanup that eliminates unused or obsolete code related to model config utilities.Removed model configuration utilities:
ssms/config/_modelconfig/utils.pyfile, which included_new_param,_get, and_new_configfunctions for constructing and managing model configuration dictionaries.Removed related tests:
tests/test_modelconfig_utils.pyfile, which contained tests for the removed utility functions, including parameter creation, config structure, and error handling.