Skip to content

slight simplifications of configs in favor of consistency#252

Merged
AlexanderFengler merged 1 commit intomainfrom
fix-model-config-keys
Jan 9, 2026
Merged

slight simplifications of configs in favor of consistency#252
AlexanderFengler merged 1 commit intomainfrom
fix-model-config-keys

Conversation

@AlexanderFengler
Copy link
Member

This pull request removes the utility functions for model configuration from ssms/config/_modelconfig/utils.py and deletes their associated unit tests in tests/test_modelconfig_utils.py. This is a cleanup that eliminates unused or obsolete code related to model config utilities.

Removed model configuration utilities:

  • Deleted the entire ssms/config/_modelconfig/utils.py file, which included _new_param, _get, and _new_config functions for constructing and managing model configuration dictionaries.

Removed related tests:

  • Deleted the tests/test_modelconfig_utils.py file, which contained tests for the removed utility functions, including parameter creation, config structure, and error handling.

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unittests 90.92% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ssms/config/_modelconfig/conflict.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexanderFengler AlexanderFengler merged commit b7af1b0 into main Jan 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant