Exgauss wald #238
Open
Exgauss wald #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Member
AlexanderFengler
left a comment
AlexanderFengler
left a comment
There was a problem hiding this comment.
Ok few high level comments:
- The current implementation I think assumes that across choice options the basic parameters for the shifted-wald, as well as ex-gaussian distributions, are the same. You actually want to allow for those to differ across choice options, so it would make sense to write the underlying simulator a priori general to allow passing e.g. a vector of
muof the length of the choice options (can take the template on dimension handling on that front from e.g.the race models) and similarly for the other parameters. - Then the simulator can operate in
bernoulli/multinomialmode, where a choice is determined by the sample from that distribution, but you can also let it operate inracemode, where a choice is determined by which of then(fornchoice options) sampledrtswas shortest. Does that make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.