[TOSA] Handle strided AtenSlice lowering #4372
Merged
+120
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower step-greater-than-one slices by reshaping to an NxKxC view, gathering rows, then restoring the original shape. Change-Id: Icc1c405b70c75831f654bbcf401ca19bc848af43
catcor01
reviewed
Nov 19, 2025
|
Looks good from my end. One last thought: are mlir tests required / make sense for this patch or are current e2e tests sufficient? |
Contributor
Author
I think e2e is fine but we'll add lit tests as well if we want it. |
|
Approved for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower step-greater-than-one slices by reshaping to an NxKxC view, gathering rows, then restoring the original shape.