[TorchToLinalg] Fix multi batch matmul conversion to Linalg #4319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored by: [email protected] Improve usage of static shape information to avoid unnecessary broadcast.
zjgarvey
requested changes
Sep 25, 2025
There was a problem hiding this comment.
Thanks for submitting the PR!
Let me know if you have trouble finding an existing utility function, since it would be better to re-use existing util functions rather than filling the current file with one-off functions.
I'd also prefer if we added a lit test to cover this change.
Comment on lines
79
to
87
| static int64_t getDimFromValue(Value dimValue) { | ||
| if (auto constOp = dimValue.getDefiningOp<arith::ConstantOp>()) { | ||
| if (auto intAttr = dyn_cast<IntegerAttr>(constOp.getValue())) { | ||
| return intAttr.getInt(); | ||
| } | ||
| } | ||
| return ShapedType::kDynamic; | ||
| } | ||
|
|
There was a problem hiding this comment.
I feel like this exact function likely already exists in some Utils.cpp file.
There may even be a computeBroadcastShape util function at this point, so I'd take a look and see if we can re-use some of that.
There was a problem hiding this comment.
Cool! I will have a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by: [email protected]
Improve usage of static shape information to avoid unnecessary broadcast.