[TorchToLinalg] : Lower count_nonzero to Linalg-on-Tensors #4145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
um-urosmarkovic
commented
Apr 17, 2025
•
um-urosmarkovic
commented
- Lowered count_nonzero op to Linalg-on-Tensors
- Decomposed aten.count_nonzero using aten.ne.Scalar and aten.sum/aten.sum.dim_IntList
- Added tests to torch-mlir/projects/pt1/python/torch_mlir_e2e_test/test_suite/reduction.py
um-urosmarkovic
force-pushed
the
feature/um-urosmarkovic/count_nonzero
branch
from
0d5418c to
441c238
Compare
|
Hi @vivekkhandelwal1 , could you please approve the workflows when you get the chance? Thanks in advance! |
um-urosmarkovic
force-pushed
the
feature/um-urosmarkovic/count_nonzero
branch
from
441c238 to
6525c97
Compare
|
Hi @vivekkhandelwal1 , I’ve rebased the branch and the CI workflows need maintainer approval again. Could you please click “Approve and run” when you have a moment? Thanks! |
vivekkhandelwal1
requested changes
Apr 22, 2025
projects/pt1/python/torch_mlir_e2e_test/test_suite/reduction.py
Outdated
Show resolved
Hide resolved
projects/pt1/python/torch_mlir_e2e_test/test_suite/reduction.py
Outdated
Show resolved
Hide resolved
projects/pt1/python/torch_mlir_e2e_test/test_suite/reduction.py
Outdated
Show resolved
Hide resolved
um-urosmarkovic
force-pushed
the
feature/um-urosmarkovic/count_nonzero
branch
from
6525c97 to
d474f6b
Compare
|
Thanks for the review, @vivekkhandelwal1! I think I have addressed all requested changes—please let me know if there’s anything else to fix. |
um-urosmarkovic
force-pushed
the
feature/um-urosmarkovic/count_nonzero
branch
from
d474f6b to
79c50e1
Compare
um-urosmarkovic
force-pushed
the
feature/um-urosmarkovic/count_nonzero
branch
from
79c50e1 to
1573ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.