Add Windows build workflow in the CI. #4041
Conversation
There was a problem hiding this comment.
Want to tag #3985 in the PR description?
| build-test-windows: | ||
| strategy: | ||
| fail-fast: true | ||
| matrix: | ||
| torch-version: [nightly] | ||
| name: Build (Windows, torch-${{ matrix.torch-version }}) | ||
| runs-on: windows-latest |
There was a problem hiding this comment.
The logs at https://github.com/llvm/torch-mlir/actions/runs/13487571031/job/37680706814?pr=4041 show this job taking 2 hours with an empty cache and the standard GitHub-hosted runners. I'd personally limit jobs running on pull_request triggers to 40-60 minutes and move longer running jobs to a lower frequency (push or schedule triggers). That might mean creating a new ci_nightly.yml workflow with different triggers.
Switching to larger self-hosted runners may be an option, but I'm not familiar with what runners are available in the llvm github organization.
Do any other torch-mlir contributors/maintainers have opinions? I don't personally work enough in this repository to know what others would be comfortable with.
| -DTORCH_MLIR_ENABLE_PYTORCH_EXTENSIONS=ON \ | ||
| -DTORCH_MLIR_ENABLE_LTC=OFF \ | ||
| -DTORCH_MLIR_ENABLE_JIT_IR_IMPORTER=ON \ | ||
| $repo_root/externals/llvm-project/llvm |
There was a problem hiding this comment.
nit: I would match the local style in this file and wrap variable expansions with {}, so ${repo_root}/externals/... and similar in other locations
Without the braces, expressions like $repo_root/build could be seen as ambiguous, as the reader needs to know that / marks the end of the variable name.
torch-nightlysince python based tests are disabled. My understanding is that without the python based tests there's no need to run against thestableversion too. If that's not the case, will enablestableas well. Tested that bothnightlyandstableversions work fine: https://github.com/sahas3/torch-mlir/actions/runs/13477124004