Add -DPython_FIND_VIRTUALENV=ONLY to cmake configure instructions #4024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required because `externals/llvm-project/mlir/cmake/modules/MLIRDetectPythonEnv.cmake` also looks for `Python` other than `Python3`.
marbre
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Seems there is now also some code upstream to warn about this
https://github.com/llvm/llvm-project/blob/f427890a1dcd7759240568f189df8fbbcf23669c/mlir/cmake/modules/MLIRDetectPythonEnv.cmake#L30-L38
I guess there could be other solutions that set the one depending on the other. This rather adds more band aid but this is probably better than leaving as is.
|
Can you resolve the conflicts @giacs-epic? |
|
I just realized that #4004 seems more complete that this, thus rather going to land #4004. However, thanks for sending a PR @giacs-epic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required because
externals/llvm-project/mlir/cmake/modules/MLIRDetectPythonEnv.cmakealso looks forPythonother thanPython3.