Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Torch]Emit AtenDetach_Op #3287

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Torch]Emit AtenDetach_Op #3287

wants to merge 2 commits into from

Conversation

Xinyu302
Copy link
Contributor

@Xinyu302 Xinyu302 commented May 6, 2024

as title

vivekkhandelwal1
vivekkhandelwal1 reviewed Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xinyu302 What do we need this for? Also, it's better if we add an op with shape and dtype information, even if we don't lower it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekkhandelwal1 vivekkhandelwal1 vivekkhandelwal1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xinyu302 @vivekkhandelwal1