Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FxImporter] Synchronize the collection of symbolic torch ops #3236

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

penguin-wwy
Copy link
Collaborator

No description provided.

@penguin-wwy
Copy link
Collaborator Author

I noticed that the version of black in our pre-commit is 22.10, is this version a bit outdated? https://github.com/psf/black/releases/tag/23.1.0 officially completed support for 3.11, I understand that we should use at least version 23.1.0, including for 3.12 in the future. @stellaraccident

@stellaraccident
Copy link
Collaborator

I noticed that the version of black in our pre-commit is 22.10, is this version a bit outdated? https://github.com/psf/black/releases/tag/23.1.0 officially completed support for 3.11, I understand that we should use at least version 23.1.0, including for 3.12 in the future. @stellaraccident

Thanks - happy to take a patch to update it (or I'll do it the next time I'm doing project maintenance). If it doesn't break anything, feel free to just land an NFC patch.

@penguin-wwy penguin-wwy merged commit 9f64748 into llvm:main Apr 29, 2024
3 checks passed
archana-ramalingam pushed a commit to archana-ramalingam/torch-mlir that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants