Switch to pre-commit for lint checks. #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellaraccident
force-pushed
the
pre-commit
branch
2 times, most recently
from
9c7f799 to
218a493
Compare
|
Before this, we haven't enabled black lint for Python code, do we need to add the black config file? |
|
excited excited excited finally no more passing around precommit gists |
stellaraccident
force-pushed
the
pre-commit
branch
from
218a493 to
bbca0ac
Compare
Added. |
archana-ramalingam
pushed a commit
to archana-ramalingam/torch-mlir
that referenced
this pull request
May 8, 2024
Users can run via `pre-commit run` or set up a hook as described in the instructions: https://pre-commit.com/ The CI is set to only run pre-commit on files changed in the patch. We will run with `--all-files` in a separate patch.
archana-ramalingam
pushed a commit
to archana-ramalingam/torch-mlir
that referenced
this pull request
May 8, 2024
Users can run via `pre-commit run` or set up a hook as described in the instructions: https://pre-commit.com/ The CI is set to only run pre-commit on files changed in the patch. We will run with `--all-files` in a separate patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can run via
pre-commit runor set up a hook as described in the instructions: https://pre-commit.com/The CI is set to only run pre-commit on files changed in the patch. We will run with
--all-filesin a separate patch.