Update setup.py #3159
Update setup.py #3159
Conversation
Removed unnecessary comments and whitespace to make the code cleaner and more concise. Simplified the check_env_flag function for better readability. Consolidated the definition of PACKAGE_VERSION to make it cleaner. Removed redundant environment variable checks and simplified their usage. Cleaned up the CustomBuild and CMakeBuild classes, removing redundant code and improving readability. Simplified the CMakeExtension class. Reorganized the imports for better readability. Removed unnecessary conversions and simplified some code blocks. Simplified the setup() function call for better readability.
|
Hi @r0cketdyne, please address the comments. The PR has been pending there for quite some time. |
licence was preserved after shebang line. env var usage docs have been retained as requested by stellaraccident.
PR has been resolved. license preserved and relevant docs at env var usage retained. |
There's still a conflict in this PR? |
resolved. |
|
2 workflows awaiting approval @stellaraccident |
|
iterating on this now. |
|
Hi @r0cketdyne, can you please do the formatting changes? |
Yes, will proceed if not today, tomorrow. |
formatting changes.
fixed EOF by adding newline
|
@vivekkhandelwal1 fixed EOF. |
There was a problem hiding this comment.
@r0cketdyne I see a lot of comments from the setup file being removed in this PR. What's the reason for that?
I simply forgot to put them back. at arch I had LDXE open and compared diffs and filtered some comments out to make it easier to spot the mismatch. Everything, as it sits should be functional. |
There was a problem hiding this comment.
Thank you for the patch. Generally, formatting/cleanup patches should be labeled "[NFC]" (non functional change) with a simple description, and in general we separate those from commingled functional changes. At first, it looked like there were no functional changes, but the imports and console scripts are materially changed.
In terms of the formatting changes, cleaning things is nice, but I'm not sure that I would introduce the churn for something like this. If you'd like to proceed, please post a patch that only contains NFC/formatting changes with a very concise description.
For the setup args changes, that needs its own patch with an explanation of why the changes are being made.
Removed unnecessary comments and whitespace to make the code cleaner and more concise.
Simplified the check_env_flag function for better readability.
Consolidated the definition of PACKAGE_VERSION to make it cleaner.
Removed redundant environment variable checks and simplified their usage.
Cleaned up the CustomBuild and CMakeBuild classes, removing redundant code and improving readability.
Simplified the CMakeExtension class.
Reorganized the imports for better readability.
Removed unnecessary conversions and simplified some code blocks.
Simplified the setup() function call for better readability.