[build] Specify numpy < 2.0 in build.requirements.txt #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the e2e tests, specifically `python -m e2e_testing.main`, many tests fail when numpy-2.X.X is installed, and an error message stating numpy-1.X.X is required. We should reflect this in the build.requirements.txt.
|
Should this be a requirement in the |
|
I've been watching these issues make their rounds on some different projects and each seems to be deciding it differently. I'd like to understand better what is going on. |
|
Hi @tdietert, I don't see any failures with the current requirements. Can you please elaborate the issue in more detail? If you're not encountering the issue anymore, then please close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the e2e tests, specifically
python -m e2e_testing.main, many tests fail when numpy-2.X.X is installed, and an error message stating numpy-1.X.X is required. We should reflect this in the build.requirements.txt.