[fx] Use module Operations instead of Module. #3046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only used in certain advanced uses of the API that want to build into their own module. The MLIR `Module` class is an awkward/restrictive way to require this to go as only some things will have it. Just switch everything to be based on a module `Operation`.
dan-garvey
force-pushed
the
fx_use_module_op
branch
from
b589acb to
6cc26e7
Compare
dan-garvey
force-pushed
the
fx_use_module_op
branch
from
6cc26e7 to
c75211f
Compare
|
Looks like there is some underlying execution engine change needed to support operation versus module? |
|
Ugh. There is stilly tech debt in the ExecutionEngine that needs to be excised... |
stellaraccident
added a commit
that referenced
this pull request
Mar 25, 2024
This is a partial landing of #3046 while waiting for an upstream change for the rest of it.
stellaraccident
added a commit
that referenced
this pull request
Mar 25, 2024
This is a partial landing of #3046 while waiting for an upstream change for the rest of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only used in certain advanced uses of the API that want to build into their own module. The MLIR
Moduleclass is an awkward/restrictive way to require this to go as only some things will have it. Just switch everything to be based on a moduleOperation.Also adds an optional visibility specifier to entry points that construct a function.