-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aten_LocalScalarDense conversion to linalg #2925
base: main
Are you sure you want to change the base?
Conversation
I'm not sure how to create an e2e test for this that will actually generate an |
Please add a test to the torch test suite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine however having a test would give me a better idea if it works
I tried to add a test, but it didn't seem to generate the _local_scalar_dense op. Do you know what torch op would generate this when we export it? When I ran into the op it was generated by |
Having trouble generating the test. Seems like it depends on tracing. I'll stamp as it does not seem worth the additional hassle. |
a58e6f0
to
2232780
Compare
rebased |
@rsuderman I don't understand the build failure here, and I'm unable to reproduce it on my machine. Do you know what the failure is? |
This is added as a ConvertAtenTensorToScalarLikeOp conversion in torch to linalg, lowering into a tensor.extract.