[Doc] Fix typo + python_package build location change #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the instructions above in `Development.md`, the build result of Python packages "torch_mlir", and "torch_mlir_e2e_test" didn't show up in `pwd/build/python_packages/torch_mlir`, but in another location that I added. To keep safe, two paths are both kept. Also, change typos.
wu-s-john
reviewed
Dec 18, 2023
| @@ -109,13 +109,13 @@ cmake --build build | |||
| ### Linux and macOS | |||
|
|
|||
| ```shell | |||
| export PYTHONPATH=`pwd`/build/python_packages/torch_mlir:`pwd`/projects/pt1/examples | |||
| export PYTHONPATH=`pwd`/build/python_packages/torch_mlir:`pwd`/build/tools/torch-mlir/python_packages/torch_mlir:`pwd`/projects/pt1/examples | |||
There was a problem hiding this comment.
No wonder I had weird issues with running integration tests 😂
wu-s-john
approved these changes
Dec 18, 2023
|
I think we should probably fix the underlying problem in cmake that is causing the divergence of paths for different users. Can you two confirm the build command you use so we can triage? From what I understand, its an issue with out of tree llvm builds? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the instructions above in
Development.md, the build result of Python packages "torch_mlir", and "torch_mlir_e2e_test" didn't show up inpwd/build/python_packages/torch_mlir, but in another location that I added.I found this path has been changed quite often in recent commits. To keep safe, both paths are kept. I have tested, and adding both locations at the same time won't hurt.
Also, change typo "tpython_packages", and add hyphens.