Skip to content

[DX] Unify multi-subresource texture upload + Texture2DArray multi-mip support (stacked) #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alsepkow wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

[DX] Unify multi-subresource texture upload + Texture2DArray multi-mip support (stacked) #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
34466ca
[DX] Support multi-mip Texture2D SRVs (#1039)
alsepkow May 27, 2026
5eb4bd0
[DX] Validate MipLevels >= 1 in getResourceDescription
alsepkow May 27, 2026
33313c8
[NFC] clang-format
alsepkow May 27, 2026
4774832
[DX] Add Texture2DArray Load support (#1077)
alsepkow May 27, 2026
2f9cd56
Merge upstream/main into alex/dx-tex-array-1077
alsepkow May 27, 2026
5355678
Merge upstream/main into alex/dx-mips-1039
alsepkow May 27, 2026
a28733a
[NFC] Add const to ReadbackDX references for clang-tidy
alsepkow May 27, 2026
2a8987d
[DX] Add RWTexture2DArray UAV support
alsepkow May 27, 2026
37d3c27
[NFC] Add const to ReadbackDX references for clang-tidy
alsepkow May 27, 2026
d1dfb11
[NFC] clang-format Texture2DArray NumSlices ternary
alsepkow May 27, 2026
b59add9
Merge remote-tracking branch 'upstream/main' into alex/dx-mips-1039
alsepkow May 30, 2026
df543ad
Merge remote-tracking branch 'upstream/main' into alex/dx-tex-array-1077
alsepkow May 30, 2026
fe4b17b
XFAIL Clang on Texture2DArray tests
alsepkow May 30, 2026
780adf1
Plumb RWTexture2DArray through VK image view type
alsepkow May 30, 2026
f591def
Merge alex/dx-tex-array-1077 to stack Tex2DArray on Tex2D mips
alsepkow Jun 2, 2026
9cf5e1e
[DX] Unify multi-subresource texture upload + add Texture2DArray mult…
alsepkow Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions include/API/Enums.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@ enum class ResourceKind {
StructuredBuffer,
ByteAddressBuffer,
Texture2D,
Texture2DArray,
RWBuffer,
RWStructuredBuffer,
RWByteAddressBuffer,
RWTexture2D,
RWTexture2DArray,
ConstantBuffer,
Sampler,
SampledTexture2D,
Expand Down
13 changes: 13 additions & 0 deletions include/Support/Pipeline.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,15 @@ static inline DescriptorKind getDescriptorKind(ResourceKind RK) {
case ResourceKind::StructuredBuffer:
case ResourceKind::ByteAddressBuffer:
case ResourceKind::Texture2D:
case ResourceKind::Texture2DArray:
case ResourceKind::AccelerationStructure:
return DescriptorKind::SRV;

case ResourceKind::RWStructuredBuffer:
case ResourceKind::RWBuffer:
case ResourceKind::RWByteAddressBuffer:
case ResourceKind::RWTexture2D:
case ResourceKind::RWTexture2DArray:
return DescriptorKind::UAV;

case ResourceKind::ConstantBuffer:
Expand Down Expand Up @@ -145,6 +147,7 @@ struct OutputProperties {
int Width;
int Depth;
int MipLevels = 1;
int ArraySize = 1;
};

static inline uint32_t getFormatSize(DataFormat Format) {
Expand Down Expand Up @@ -246,7 +249,9 @@ struct Resource {
case ResourceKind::Buffer:
case ResourceKind::RWBuffer:
case ResourceKind::Texture2D:
case ResourceKind::Texture2DArray:
case ResourceKind::RWTexture2D:
case ResourceKind::RWTexture2DArray:
case ResourceKind::Sampler:
case ResourceKind::SampledTexture2D:
case ResourceKind::AccelerationStructure:
Expand All @@ -273,7 +278,9 @@ struct Resource {
case ResourceKind::RWByteAddressBuffer:
case ResourceKind::ConstantBuffer:
case ResourceKind::Texture2D:
case ResourceKind::Texture2DArray:
case ResourceKind::RWTexture2D:
case ResourceKind::RWTexture2DArray:
case ResourceKind::SampledTexture2D:
case ResourceKind::AccelerationStructure:
return false;
Expand All @@ -294,7 +301,9 @@ struct Resource {
case ResourceKind::AccelerationStructure:
return false;
case ResourceKind::Texture2D:
case ResourceKind::Texture2DArray:
case ResourceKind::RWTexture2D:
case ResourceKind::RWTexture2DArray:
case ResourceKind::SampledTexture2D:
return true;
}
Expand Down Expand Up @@ -356,6 +365,7 @@ struct Resource {
case ResourceKind::StructuredBuffer:
case ResourceKind::ByteAddressBuffer:
case ResourceKind::Texture2D:
case ResourceKind::Texture2DArray:
case ResourceKind::ConstantBuffer:
case ResourceKind::Sampler:
case ResourceKind::SampledTexture2D:
Expand All @@ -365,6 +375,7 @@ struct Resource {
case ResourceKind::RWStructuredBuffer:
case ResourceKind::RWByteAddressBuffer:
case ResourceKind::RWTexture2D:
case ResourceKind::RWTexture2DArray:
return true;
}
llvm_unreachable("All cases handled");
Expand Down Expand Up @@ -829,10 +840,12 @@ template <> struct ScalarEnumerationTraits<offloadtest::ResourceKind> {
ENUM_CASE(StructuredBuffer);
ENUM_CASE(ByteAddressBuffer);
ENUM_CASE(Texture2D);
ENUM_CASE(Texture2DArray);
ENUM_CASE(RWBuffer);
ENUM_CASE(RWStructuredBuffer);
ENUM_CASE(RWByteAddressBuffer);
ENUM_CASE(RWTexture2D);
ENUM_CASE(RWTexture2DArray);
ENUM_CASE(ConstantBuffer);
ENUM_CASE(Sampler);
ENUM_CASE(SampledTexture2D);
Expand Down
Loading
Loading