[Fortran] Disable gfortran volatile8 test #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test expects the compiler to give a compilation error. Current LLVM flang does emit an error, but it's a TODO message because volatile variables are not handled yet. There are upcoming PRs to enable this though, and the front end ought to emit some diagnostic about this. Eugene E and Peter K are discussing whether these should be warnings or errors. While this is being discussed, disable the test so work on volatile can proceed. llvm-project#137369
tarunprabhu
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
Once the discussion on how to handle this is resolved, could you update the comment to provide a bit more detail? At some point, we need to go through and decide which tests should be permanently disabled, and which could be handled differently*. A more detailed comment would be of great help. Thanks!
* There is a mechanism to override the 'xfail' status of a test without modifying the test itself).
|
Yes! We intend on re-enabling this test, so it should not be disabled for long. Just so buildbots are green while we're in transition. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test expects the compiler to give a compilation error. Current LLVM flang does emit an error, but it's a TODO message because volatile variables are not handled yet. There are upcoming PRs to enable this though, and the front end ought to emit some diagnostic about this. Eugene E and Peter K are discussing whether these should be warnings or errors. While this is being discussed, disable the test so work on volatile can proceed.
LLVM PR requiring this change
LLVM issue discussing how to handle this test case
CC @kiranchandramohan @eugeneepshteyn @vzakhari