Skip to content

[SPEC2017] Add dependencies required for compiletime measurements to the wrf_netcdf target of 521.wrf_r #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SixWeining
Copy link
Contributor

Without this change, Fortran benchmarks of SPEC2017 fail to build. Steps to reproduce:

$ cmake -B builddir \
-DCMAKE_C_COMPILER=clang \
-DCMAKE_CXX_COMPILER=clang++ \
-DCMAKE_Fortran_COMPILER=flang \
-G Ninja \
-C cmake/caches/O3.cmake \
-DTEST_SUITE_SPEC2017_ROOT=path/to/cpu2017-v1.1.5 \ -DTEST_SUITE_RUN_TYPE=ref \
-DTEST_SUITE_FORTRAN=ON \
-DCMAKE_C_FLAGS=-Wno-implicit-int \
-DCMAKE_CXX_FLAGS=-Wno-implicit-int

$ cmake --build builddir/ -j1
[0/2] Re-checking globbed directories...
[1951/35275] Building C object External/SPEC/CFP2017rate/521.wrf_r/CMakeFiles/wrf_netcdf.dir/__/__/cpu2017-v1.1.5/benchspec/CPU/521.wrf_r/src/netcdf/attr.c.o FAILED:
...
/bin/sh: 1: builddir/tools/timeit: not found

…the wrf_netcdf target of 521.wrf_r

Without this change, Fortran benchmarks of SPEC2017 fail to build. Steps to reproduce:

$ cmake -B builddir \
-DCMAKE_C_COMPILER=clang \
-DCMAKE_CXX_COMPILER=clang++ \
-DCMAKE_Fortran_COMPILER=flang \
-G Ninja \
-C cmake/caches/O3.cmake \
-DTEST_SUITE_SPEC2017_ROOT=path/to/cpu2017-v1.1.5 \
-DTEST_SUITE_RUN_TYPE=ref \
-DTEST_SUITE_FORTRAN=ON \
-DCMAKE_C_FLAGS=-Wno-implicit-int \
-DCMAKE_CXX_FLAGS=-Wno-implicit-int

$ cmake --build builddir/
[0/2] Re-checking globbed directories...
[1932/35275] Building C object External/SPEC/CFP2017rate/521.wrf_r/CMakeFiles/wrf_netcdf.dir/__/__/cpu2017-v1.1.5/benchspec/CPU/521.wrf_r/src/netcdf/attr.c.o
FAILED:
...
/bin/sh: 1: builddir/tools/timeit: not found
Copy link
Contributor

@lukel97 lukel97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I presume it's because this fortran library doesn't use llvm_test_library? And FWIW I can see SNAP also does the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants