Skip to content

[Fortran] disable pointer_check_11.f90 which exhibits UB #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/20.x
Choose a base branch
from

Conversation

tblah
Copy link
Contributor

@tblah tblah commented Apr 15, 2025

This test calls an empty subroutine with a null pointer as an argument. In gfortran it is hoped that a flag will detect this and produce an error. Flang does not perform any such analysis, and so on some machines when optimization is enabled, this test never terminates. I don't think this is a flang bug as such because the input code is doing undefined behaviour.

This is a cherry-pick of #232 to the 20.x release branch. I'm not sure how this works for llvm-test-suite as there appears to be no bot.

This test calls an empty subroutine with a null pointer as an argument.
In gfortran it is hoped that a flag will detect this and produce an
error. Flang does not perform any such analysis, and so on some machines
when optimization is enabled, this test never terminates. I don't think
this is a flang bug as such because the input code is doing undefined
behaviour.
@tblah tblah changed the title [Fortran] disable pointer_check_11.f90 which exhibits UB (#232) [Fortran] disable pointer_check_11.f90 which exhibits UB Apr 15, 2025
@tblah
Copy link
Contributor Author

tblah commented Apr 15, 2025

@tstellar is this allowed? Is there a process that should be followed here?

I'm not sure how the releases work for llvm-test-suite

Copy link

@pawosm-arm pawosm-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it looks OK, I experienced it when working with the release/20.x branch, so I'm interested in it being cherry-picked.

@DavidTruby
Copy link
Member

I think there shouldn't be an issue merging to the release branch for the test suite? @tarunprabhu do you have an opinion since you reviewed this patch for the main branch?

@tarunprabhu
Copy link
Contributor

I think there shouldn't be an issue merging to the release branch for the test suite? @tarunprabhu do you have an opinion since you reviewed this patch for the main branch?

I don't think that merging it into the release branch should cause any problems. But I also don't know if there is a precedent or process to be followed for doing this in the test-suite. I'm happy to approve this, conditional on getting an ok from someone who knows more about the test suite's policies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants