[lld][ELF] Delete useless assertions

[kovdan01]

Assertions in the member functions below are considered not useful. See #96169 (comment)

• GotSection::addEntry
• GotSection::addTlsDescEntry
• GotSection::addDynTlsEntry

[llvmbot]

@llvm/pr-subscribers-lld

@llvm/pr-subscribers-lld-elf

Author: Daniil Kovalev (kovdan01)

Changes

Assertions in the member functions below are considered not useful. See #96169 (comment)

• GotSection::addEntry
• GotSection::addTlsDescEntry
• GotSection::addDynTlsEntry

---

Full diff: https://github.com/llvm/llvm-project/pull/98028.diff

1 Files Affected:

• (modified) lld/ELF/SyntheticSections.cpp (-3)

diff --git a/lld/ELF/SyntheticSections.cpp b/lld/ELF/SyntheticSections.cpp
index 5d3f3df216b85..624dfd94ce8bf 100644
--- a/lld/ELF/SyntheticSections.cpp
+++ b/lld/ELF/SyntheticSections.cpp
@@ -653,19 +653,16 @@ GotSection::GotSection()
 
 void GotSection::addConstant(const Relocation &r) { relocations.push_back(r); }
 void GotSection::addEntry(const Symbol &sym) {
-  assert(sym.auxIdx == symAux.size() - 1);
   symAux.back().gotIdx = numEntries++;
 }
 
 bool GotSection::addTlsDescEntry(const Symbol &sym) {
-  assert(sym.auxIdx == symAux.size() - 1);
   symAux.back().tlsDescIdx = numEntries;
   numEntries += 2;
   return true;
 }
 
 bool GotSection::addDynTlsEntry(const Symbol &sym) {
-  assert(sym.auxIdx == symAux.size() - 1);
   symAux.back().tlsGdIdx = numEntries;
   // Global Dynamic TLS entries take two GOT slots.
   numEntries += 2;

[MaskRay]

assert(sym.auxIdx == symAux.size() - 1); assertions are useful to prevent allocating more than one entries for one symbol. I used the assertions to prevent some failures. NEEDS_GOT_AUTH is clearly AArch64 specific.