Skip to content

[lit] Read stdin for a "-" operand in builtin cat #240060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thejesh23 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

[lit] Read stdin for a "-" operand in builtin cat #240060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion llvm/utils/lit/lit/builtin_commands/cat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ def run(argv, stdin, stdout, stderr, cwd):

contents = None
is_text = False
if platform.system() == "OS/390":
if filename == "-":
contents = stdin.read()
elif platform.system() == "OS/390":
try:
with open(path, "r") as fileToCat:
contents = fileToCat.read()
Expand Down
12 changes: 12 additions & 0 deletions llvm/utils/lit/tests/Inputs/shtest-cat/cat.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,15 @@
## Test that cat will pipe stdin to stdout if no other files are specified.
# RUN: echo test | cat | FileCheck --check-prefix=CAT-STDIN %s
# CAT-STDIN: test

## Test that cat reads stdin in place of a "-" operand.
# RUN: rm -rf %t
# RUN: mkdir -p %t
# RUN: echo "abcdefgh" > %t/temp1.write
# RUN: echo "mnopqrst" > %t/temp2.write
# RUN: echo "efghijkl" | cat %t/temp1.write - %t/temp2.write | \
# RUN: FileCheck --check-prefix=DASH-CAT-OUTPUT --implicit-check-not={{.}} \
# RUN: --match-full-lines --strict-whitespace %s
# DASH-CAT-OUTPUT:abcdefgh
# DASH-CAT-OUTPUT-NEXT:efghijkl
# DASH-CAT-OUTPUT-NEXT:mnopqrst