Skip to content

Conversation

@vitalybuka
Copy link
Collaborator

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Nov 10, 2025

@llvm/pr-subscribers-llvm-support

Author: Vitaly Buka (vitalybuka)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/167279.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Support/SpecialCaseList.h (+4-4)
diff --git a/llvm/include/llvm/Support/SpecialCaseList.h b/llvm/include/llvm/Support/SpecialCaseList.h
index f904e582b5cee..8c4dc94ae54ce 100644
--- a/llvm/include/llvm/Support/SpecialCaseList.h
+++ b/llvm/include/llvm/Support/SpecialCaseList.h
@@ -197,14 +197,14 @@ class SpecialCaseList {
 protected:
   class Section {
   public:
-    Section(StringRef Str, unsigned FileIdx, bool UseGlobs)
-        : SectionMatcher(UseGlobs, /*RemoveDotSlash=*/false), SectionStr(Str),
+    Section(StringRef Name, unsigned FileIdx, bool UseGlobs)
+        : SectionMatcher(UseGlobs, /*RemoveDotSlash=*/false), Name(Name),
           FileIdx(FileIdx) {}
 
     Section(Section &&) = default;
 
     // Return name of the section, it's entire string in [].
-    StringRef name() const { return SectionStr; }
+    StringRef name() const { return Name; }
 
     // Returns true of string 'Name' matches section name interpreted as a glob.
     LLVM_ABI bool matchName(StringRef Name) const;
@@ -232,7 +232,7 @@ class SpecialCaseList {
     findMatcher(StringRef Prefix, StringRef Category) const;
 
     Matcher SectionMatcher;
-    StringRef SectionStr;
+    StringRef Name;
     SectionEntries Entries;
     unsigned FileIdx;
   };

vitalybuka added a commit to vitalybuka/llvm-project that referenced this pull request Nov 10, 2025
petrhosek and others added 2 commits November 10, 2025 17:57
Created using spr 1.3.7

[skip ci]
Created using spr 1.3.7
@vitalybuka vitalybuka changed the base branch from users/vitalybuka/spr/main.nfcspecialcaselist-rename-sectionsectionstr-to-name to main November 11, 2025 01:57
@vitalybuka vitalybuka requested a review from Copilot November 11, 2025 01:57
Copilot finished reviewing on behalf of vitalybuka November 11, 2025 01:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the Section::SectionStr member variable to Name for improved clarity and consistency with the class's name() accessor method.

  • Renames the private member variable SectionStr to Name
  • Updates the constructor parameter from Str to Name to match
  • Updates all references to use the new naming

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Created using spr 1.3.7
@vitalybuka vitalybuka enabled auto-merge (squash) November 11, 2025 02:00
@vitalybuka vitalybuka disabled auto-merge November 11, 2025 02:00
@vitalybuka vitalybuka enabled auto-merge (squash) November 11, 2025 02:00
@vitalybuka vitalybuka merged commit ae1e2ec into main Nov 11, 2025
10 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/nfcspecialcaselist-rename-sectionsectionstr-to-name branch November 11, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants