Skip to content

[NFC][SpecialCaseList] Store SectionStr as StringRef #167278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 11, 2025
Merged

[NFC][SpecialCaseList] Store SectionStr as StringRef #167278

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87357c1
[𝘀𝗽𝗿] changes to main this commit is based on
vitalybuka Nov 10, 2025
7550efc
[𝘀𝗽𝗿] initial version
vitalybuka Nov 10, 2025
837afe7
[𝘀𝗽𝗿] changes introduced through rebase
arsenm Nov 10, 2025
7c368b9
rebase
vitalybuka Nov 10, 2025
4b95caa
rebas
vitalybuka Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/include/llvm/Support/SpecialCaseList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ class SpecialCaseList {
findMatcher(StringRef Prefix, StringRef Category) const;

Matcher SectionMatcher;
std::string SectionStr;
StringRef SectionStr;
SectionEntries Entries;
unsigned FileIdx;
};
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/Support/SpecialCaseList.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,10 @@ bool SpecialCaseList::createInternal(const MemoryBuffer *MB, std::string &Error,
Expected<SpecialCaseList::Section *>
SpecialCaseList::addSection(StringRef SectionStr, unsigned FileNo,
unsigned LineNo, bool UseGlobs) {
SectionStr = SectionStr.copy(StrAlloc);
Sections.emplace_back(SectionStr, FileNo, UseGlobs);
auto &Section = Sections.back();

SectionStr = SectionStr.copy(StrAlloc);
if (auto Err = Section.SectionMatcher.insert(SectionStr, LineNo)) {
return createStringError(errc::invalid_argument,
"malformed section at line " + Twine(LineNo) +
Expand Down
Loading