Skip to content

[WebAssembly,MC] Add ref.test_func handling to AsmParser #139642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025
Merged

[WebAssembly,MC] Add ref.test_func handling to AsmParser #139642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba4e214
[WebAssembly] Add ref.test_func handling to AsmParser
hoodmane May 11, 2025
6a4693a
Rename to ref.test
hoodmane May 13, 2025
06f4435
Add comment
hoodmane Jul 7, 2025
c294f9c
Clang-format
hoodmane Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,10 @@ class WebAssemblyAsmParser final : public MCTargetAsmParser {
if (parseFunctionTableOperand(&FunctionTable))
return true;
ExpectFuncType = true;
} else if (Name == "ref.test") {
// When we get support for wasm-gc types, this should become
// ExpectRefType.
ExpectFuncType = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the long run I guess this should instead be something like ExpectRefType?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah exactly. But there is no such thing yet...

Copy link
Contributor Author

@hoodmane hoodmane Jul 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment/

}

// Returns true if the next tokens are a catch clause
Expand Down
8 changes: 8 additions & 0 deletions llvm/lib/Target/WebAssembly/WebAssemblyInstrRef.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ multiclass REF_I<WebAssemblyRegClass rc, ValueType vt, string ht> {
Requires<[HasReferenceTypes]>;
}

defm REF_TEST_FUNCREF :
I<(outs I32: $res),
(ins TypeIndex:$type, FUNCREF: $ref),
(outs),
(ins TypeIndex:$type),
[],
"ref.test\t$type, $ref", "ref.test $type", 0xfb14>;

defm "" : REF_I<FUNCREF, funcref, "func">;
defm "" : REF_I<EXTERNREF, externref, "extern">;
defm "" : REF_I<EXNREF, exnref, "exn">;
Expand Down
15 changes: 15 additions & 0 deletions llvm/test/MC/WebAssembly/reference-types.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,21 @@ ref_null_test:
drop
end_function

# CHECK-LABEL: ref_test_test:
# CHECK: ref.null_func # encoding: [0xd0,0x70]
# CHECK: ref.test () -> () # encoding: [0xfb,0x14,0x80'A',0x80'A',0x80'A',0x80'A',A]
# CHECK: # fixup A - offset: 2, value: .Ltypeindex0@TYPEINDEX, kind: fixup_uleb128_i32
# CHECK: ref.null_func # encoding: [0xd0,0x70]
# CHECK: ref.test () -> (i32) # encoding: [0xfb,0x14,0x80'A',0x80'A',0x80'A',0x80'A',A]
# CHECK: # fixup A - offset: 2, value: .Ltypeindex1@TYPEINDEX, kind: fixup_uleb128_i32
ref_test_test:
.functype ref_test_test () -> (i32, i32)
ref.null_func
ref.test () -> ()
ref.null_func
ref.test () -> (i32)
end_function

# CHECK-LABEL: ref_sig_test_funcref:
# CHECK-NEXT: .functype ref_sig_test_funcref (funcref) -> (funcref)
ref_sig_test_funcref:
Expand Down
Loading