[lldb-dap] Remove the lldb-vscode symlink (NFC) #139621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the lldb-vscode -> lldb-dap symlink in the tools directory. I initially created the symlink when we renamed the tool to make migration easier. I think enough time has passed that we don't need it anymore. My personal motivation is that the symlink causes every file in the lldb-dap directory to show up twice (once under lldb-dap and once under lldb-vscode) in Quick Open in VS Code.
|
@llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) ChangesRemove the My personal motivation is that the symlink causes every file in the Full diff: https://github.com/llvm/llvm-project/pull/139621.diff 1 Files Affected:
diff --git a/lldb/tools/lldb-vscode b/lldb/tools/lldb-vscode
deleted file mode 120000
index 46b40044086c9..0000000000000
--- a/lldb/tools/lldb-vscode
+++ /dev/null
@@ -1 +0,0 @@
-lldb-dap
\ No newline at end of file
|
ashgti
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
lldb-vscode->lldb-dapsymlink in thetoolsdirectory. I initially created the symlink when we renamed the tool to make migration easier. I think enough time has passed that we don't need it anymore.My personal motivation is that the symlink causes every file in the
lldb-dapdirectory to show up twice (once underlldb-dapand once underlldb-vscode) in Quick Open in VS Code.