Skip to content

[BOLT][NFCI] Switch heatmap to using parsed basic/branch events #136531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: users/aaupov/spr/main.boltnfci-switch-heatmap-to-using-parsed-basicbranch-events
Choose a base branch
from

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Apr 21, 2025

No description provided.

Created using spr 1.3.4
Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- bolt/include/bolt/Profile/DataAggregator.h bolt/include/bolt/Profile/Heatmap.h bolt/lib/Profile/DataAggregator.cpp bolt/lib/Profile/Heatmap.cpp
View the diff from clang-format here.
diff --git a/bolt/lib/Profile/DataAggregator.cpp b/bolt/lib/Profile/DataAggregator.cpp
index ef4799f59..04888ca9d 100644
--- a/bolt/lib/Profile/DataAggregator.cpp
+++ b/bolt/lib/Profile/DataAggregator.cpp
@@ -1346,7 +1346,7 @@ std::error_code DataAggregator::printHeatMap() {
   outs() << "HEATMAP: building heat map...\n";
 
   if (opts::BasicAggregation) {
-    for (const auto &[PC, Hits]: BasicSamples)
+    for (const auto &[PC, Hits] : BasicSamples)
       HM.registerAddress(PC, Hits);
   } else {
     for (const auto &[Trace, Info] : FallthroughLBRs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant