Point workflow yaml at new docker image#133359
Draft
gburgessiv wants to merge 1 commit intollvm:mainfrom
Draft
Conversation
gburgessiv
force-pushed
the
point-workflow-yaml-at-new-docker-image
branch
from
2000467 to
33650c8
Compare
gburgessiv
force-pushed
the
point-workflow-yaml-at-new-docker-image
branch
11 times, most recently
from
3a839f2 to
76bd0a9
Compare
Member
Author
So this saves somewhere from 40-60 seconds per run on Linux, assuming we expect to build new images roughly monthly. I'll test Win next, but shaving the better part of a minute of per-run init off in exchange for 60s of VM startup time sounds like a win to me. Sounds like we might be able to make this docker image part of our cloud image at some point, which should take the VM startup cost to near-0. |
gburgessiv
force-pushed
the
point-workflow-yaml-at-new-docker-image
branch
from
df7a9c8 to
830ab92
Compare
This is now baked into the docker images to speed up premerge cycle times. llvm#133359 (comment) has initial numbers on the benefits we see in practice on bots.
gburgessiv
force-pushed
the
point-workflow-yaml-at-new-docker-image
branch
from
830ab92 to
2332c97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP; docker image hasn't landed yet (see #133137), but I want to see what wins can be verified/bugs can be found outside-of-production.