release/20.x: [llvm-objcopy][ReleaseNotes] Fix prints wrong path when dump-section output path doesn't exist #125345 #126607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dump-section output path doesn't exist llvm#125345
MaskRay
approved these changes
Feb 11, 2025
llvm/docs/ReleaseNotes.md
Outdated
| `--localize-symbol`, `--localize-symbols`, | ||
| `--skip-symbol`, `--skip-symbols`. | ||
|
|
||
| * llvm-objcopy now prints the correct file path in the error message when the output file specified by --dump-section cannot be opened. |
There was a problem hiding this comment.
double quotes around the option name.
There was a problem hiding this comment.
I made it --dump-section to be similar to all other options in the same file
|
@AmrDeveloper (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add release note for llvm-objcopy fixing prints wrong path when dump-section output path doesn't exist in #125345