This repository was archived by the owner on Feb 21, 2026. It is now read-only.
[CIR][CIRGen] Support for builtin __atomic_thread_fence#1287
Merged
bcardosolopes merged 2 commits intollvm:mainfrom Feb 12, 2025
Merged
[CIR][CIRGen] Support for builtin __atomic_thread_fence#1287bcardosolopes merged 2 commits intollvm:mainfrom
__atomic_thread_fence#1287bcardosolopes merged 2 commits intollvm:mainfrom
Conversation
Member
Author
|
I have just created the ODS definition at the moment to be sure if this is the way to go. |
4 tasks
Rajveer100
force-pushed
the
atomic-thread_signal-fence
branch
from
969faf7 to
c2cc1a9
Compare
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Initial step looks good, some inline comments. Note that this PR should come with CIRGen and LLVM lowering support, I suggest you first handle a very simple case of the fence and mark all paths not currently support with llvm_unrecheable("NYI"), so that you can go about working in incremental PRs to complete this.
bcardosolopes
changed the title
__atomic_thread_fence__atomic_thread_fence
Rajveer100
force-pushed
the
atomic-thread_signal-fence
branch
from
c2cc1a9 to
e8758ac
Compare
Member
|
We just went over a rebase against upstream, apologies for the churn but please update your branch for this PR and force-push! |
Rajveer100
force-pushed
the
atomic-thread_signal-fence
branch
from
e8758ac to
ca75a57
Compare
bcardosolopes
suggested changes
Jan 29, 2025
ghehg
reviewed
Feb 3, 2025
Rajveer100
force-pushed
the
atomic-thread_signal-fence
branch
2 times, most recently
from
6425312 to
97fb189
Compare
Member
Author
|
Do we need a new definition for |
Contributor
That is kinda of territory of LLVM dialect. Currently llvm.fenceop uses stringattr to represent syncscope, and I assume it works meaning it lowers to LLVM IR without problem if we set it with right string value from clangir lowering to LLVM (dialect) |
ghehg
reviewed
Feb 6, 2025
Rajveer100
force-pushed
the
atomic-thread_signal-fence
branch
from
97fb189 to
39bfe2b
Compare
Member
Author
|
From my sight I can see the following nits:
|
ghehg
reviewed
Feb 7, 2025
Rajveer100
force-pushed
the
atomic-thread_signal-fence
branch
2 times, most recently
from
1a626c7 to
83b33a7
Compare
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
Mostly good, few nits and ready to go
Rajveer100
force-pushed
the
atomic-thread_signal-fence
branch
from
83b33a7 to
8f81369
Compare
Rajveer100
force-pushed
the
atomic-thread_signal-fence
branch
from
8f81369 to
35d7898
Compare
Contributor
|
LGMT, too |
Rajveer100
force-pushed
the
atomic-thread_signal-fence
branch
from
35d7898 to
9699710
Compare
Resolves llvm#1274 Implements atomic thread fence synchronization primitive corresponding to `atomic.thread_fence` CIR.
Rajveer100
force-pushed
the
atomic-thread_signal-fence
branch
2 times, most recently
from
a191e33 to
0a24062
Compare
Rajveer100
force-pushed
the
atomic-thread_signal-fence
branch
from
0a24062 to
0ed0cb6
Compare
bcardosolopes
approved these changes
Feb 12, 2025
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
Fix #1274 Implements atomic thread fence synchronization primitive corresponding to `atomic.thread_fence` CIR.
terapines-osc-cir
pushed a commit
to Terapines/clangir
that referenced
this pull request
Sep 2, 2025
Fix llvm#1274 Implements atomic thread fence synchronization primitive corresponding to `atomic.thread_fence` CIR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1274
Implements atomic thread fence synchronization primitive corresponding to
atomic.thread_fenceCIR.