Fail when clang FE returned an error #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aobolensk
commented
Jan 1, 2024
•
aobolensk
commented
- Add check if clang diagnostics engine reported any errors
- Fix tests that started to fail after clang FE diagnostics checks enabling
- Add basic tests for handling invalid C++ code by cgeist
aobolensk
force-pushed
the
aobolensk/no-ignore-clang-diag
branch
from
49999da to
2e3f418
Compare
- Add check if clang diagnostics engine reported any errors - Add basic tests for handling invalid C++ code by cgeist
aobolensk
force-pushed
the
aobolensk/no-ignore-clang-diag
branch
from
2e3f418 to
603f5a7
Compare
wsmoses
reviewed
Jan 2, 2024
| @@ -0,0 +1,3 @@ | |||
| // RUN: not cgeist %s --function=* -S | |||
|
|
|||
There was a problem hiding this comment.
change this to instead check for failure with // XFAIL: *
wsmoses
reviewed
Jan 2, 2024
tools/cgeist/driver.cc
Outdated
| gpuTriple, gpuDL); | ||
| if (!parseMLIR(argv[0], files, cfunction, includeDirs, defines, module, | ||
| triple, DL, gpuTriple, gpuDL)) { | ||
| llvm::errs() << "parseMLIR failed\n"; |
There was a problem hiding this comment.
Remove this print and presumably we'll still print the error message from the original clang?
There was a problem hiding this comment.
Yes, it will be printed. Removed additional parseMLIR failed printing
wsmoses
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.