Skip to content

er_fill works improperly when using 4-connected. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gylns wants to merge 1 commit into
base: master
Choose a base branch
from
Open

er_fill works improperly when using 4-connected. #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ int main( int argc, char** argv )
//t = (double)cvGetTickCount();

for (int i=0; i<regions.size(); i++)
regions[i].er_fill(grey);
regions[i].er_fill(grey, mser8.connect8());

//t = cvGetTickCount() - t;
//cout << "Regions filled in " << t/((double)cvGetTickFrequency()*1000.) << " ms." << endl;
Expand Down
3 changes: 3 additions & 0 deletions mser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ class MSER
/// @param[in] height Height of the image.
/// @param[out] regions Detected MSER.
void operator()(const uint8_t * bits, int width, int height, std::vector<Region> & regions);

// return true if use 8-connected, otherwise false.
bool connect8(){ return eight_; }

private:
// Helper method
Expand Down
4 changes: 2 additions & 2 deletions region.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ All rights reserved.
The function is part of the VLFeat library and is made available under
the terms of the BSD license (see the COPYING file).
*/
void Region::er_fill(Mat& _grey_img)
void Region::er_fill(Mat& _grey_img, bool _eight )
{
const uint8_t *src = (uint8_t*)_grey_img.data;

Expand Down Expand Up @@ -254,7 +254,7 @@ void Region::er_fill(Mat& _grey_img)
4 - the pixel has not been visited yet
*/
if(good
&& nindex != index
&& (nindex != index && (_eight || !(nsubs_pt[0] & nsubs_pt[1])))
&& ((!invert && I_pt [nindex] <= value) ||
( invert && I_pt [nindex] >= value))
&& ! visited_pt [nindex] ) {
Expand Down
2 changes: 1 addition & 1 deletion region.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class Region

/// Fills an Extremal Region (ER) by region growing from the Index of the initial pixel(pixel_).
/// @param[in] grey_img Grey level image
void er_fill(cv::Mat& _grey_img);
void er_fill(cv::Mat& _grey_img, bool _eight = false);

std::vector<int> pixels_; ///< list pf all pixels indexes (y * width + x) of the region

Expand Down