Repository navigation
Clarify Laghos floating point precision modifications - #87
Merged
Merged
Conversation
…running in just single precision is not.
Collaborator
|
@kennyweiss Please take a look at this wording, we will want to think about this. |
pearce8
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pearce8 Let me know if this wording is what you were expecting. The main gist is we still want double precision level accuracy (maybe not full IEEE compliant) so emulation is ok, but just switching everything to single precision is not ok.
This is only for the "vendors are allowed to make modifications" number; the no modifications allowed numbers must use IEEE double precision.