Open
Conversation
jcs15c
changed the title
jcs15c
force-pushed
the
feature/spainhour/threaded_gwn
branch
from
ebd7cb6 to
6437782
Compare
jcs15c
requested review from
Arlie-Capps,
BradWhitlock,
bmhan12,
kennyweiss and
rhornung67
jcs15c
force-pushed
the
feature/spainhour/threaded_gwn
branch
from
0aa11d6 to
075e008
Compare
jcs15c
force-pushed
the
feature/spainhour/threaded_gwn
branch
2 times, most recently
from
f1c735c to
1186e6d
Compare
jcs15c
force-pushed
the
feature/spainhour/threaded_gwn
branch
from
1186e6d to
27b914d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds OMP support for the GWN examples in
quest, which threading cache creation per surface and GWN evaluation per query. These changes are supported by adding "cache manager" classes towinding_number_2d/3d_memoization.hppwhich provide a view to GWN caches used in execution, and a mutex inquadrature.cppto ensure thread safety. For OMP examples, a separate cache is allocated for each thread. In the future, it might be worth investigating if there are benefits to collocating/binning the query points used for each thread to improve cache utilization. These changes are tested inquest_gwn_methods.cpp.Many thanks to @BradWhitlock for the initial implementation of these methods, from which this PR is mostly derived.