Open
Conversation
ScuffedNewt
force-pushed
the
feature/calendar
branch
from
fdd0eeb to
461170b
Compare
Contributor
Author
|
|
itinerare
added
enhancement
AW0005
reviewed
Aug 22, 2023
SpeedyD
approved these changes
Mar 24, 2024
Contributor
There was a problem hiding this comment.
Looking at this again with a fresh mindset half a year later, I think it's decent. It'll need a bit of testing and fine tuning, I'm sure, but it's the develop branch.. we'll get there.
EDIT: In approval-hindsight, this may actually need a few updates to 3.1.0 first, won't it..?
Contributor
|
Dear @ScuffedNewt, may I kindly request that, now that it has been officially nine months since your last update, that you re-merge the develop branch into this? There are conflicts, unfortunately. |
…feature/calendar # Conflicts: # config/lorekeeper/settings.php
SpeedyD
approved these changes
Jan 27, 2025
Contributor
SpeedyD
left a comment
SpeedyD
left a comment
There was a problem hiding this comment.
Just. Re-approving just in case it's needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for sales/prompts/news