fix: erroneous query generation on currency log search#1440
Open
perappu wants to merge 2 commits intolk-arpg:developfrom
Open
fix: erroneous query generation on currency log search#1440perappu wants to merge 2 commits intolk-arpg:developfrom
perappu wants to merge 2 commits intolk-arpg:developfrom
Conversation
ScuffedNewt
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling getCurrencyLogs(), the way the SQL generates currently is:
...which, when chained with additional where clauses in the search function, causes some odd display behavior at times (users reported some currencies not showing at all, not showing logs where users transferred them currency, strange ordering, etc). You can see it when searching for a specific user within someone's currency logs here:
This PR creates additional parentheses in the SQL so chained where()'s are properly handled:
So now, when searching for a user:
I also applied the same fix to characters for consistency's sake (maybe somebody will add search there someday). Also don't ask me why the intval()s were needed, I'm not fully sure either, but it was handling weird without them, lol.
This would theoretically also be an issue on v3, but it never happens because getCurrencyLogs() returns a collection and not a query.